Skip to content

Commit c95b291

Browse files
committed
Merge pull request #7 from mmv/master
Protect against libraries that extend Array.prototype
2 parents 7e6da09 + 76123ec commit c95b291

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

diffview.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,10 +188,10 @@ diffview = {
188188
node2.setAttribute("href", "http://github.com/cemerick/jsdifflib");
189189

190190
tdata.push(node = document.createElement("tbody"));
191-
for (var idx in rows) node.appendChild(rows[idx]);
191+
for (var idx in rows) rows.hasOwnProperty(idx) && node.appendChild(rows[idx]);
192192

193193
node = celt("table", "diff" + (inline ? " inlinediff" : ""));
194-
for (var idx in tdata) node.appendChild(tdata[idx]);
194+
for (var idx in tdata) tdata.hasOwnProperty(idx) && node.appendChild(tdata[idx]);
195195
return node;
196196
}
197-
}
197+
}

0 commit comments

Comments
 (0)