Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit d0ad57c

Browse files
authored
Add a "noci" tag for tests that should run locally and build but not run in Travis. (#31)
stats_plugin_end2end_test is minorly flaky locally but times out with very high probability in Travis, seemingly due to local-port issues. exporter_example runs very slowly due to sleeps and does not provide value as a test.
1 parent 604a7f4 commit d0ad57c

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ script:
1313
# We can't use --noshow_progress because Travis terminates the
1414
# build after 10 mins without output.
1515
- bazel build --experimental_ui_actions_shown=1 -k $(bazel query ... | grep -v :_)
16-
- bazel test --experimental_ui_actions_shown=1 -k $(bazel query ... | grep -v :_)
16+
- bazel test --experimental_ui_actions_shown=1 -k $(bazel query "kind(test, //...) except attr('tags', 'noci', //...)" | grep -v :_)

opencensus/plugins/BUILD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,11 @@ cc_test(
6262
name = "stats_plugin_end2end_test",
6363
srcs = ["internal/stats_plugin_end2end_test.cc"],
6464
copts = TEST_COPTS,
65+
flaky = True, # RPCs are unreliable.
6566
linkopts = [
6667
"-pthread",
6768
],
69+
tags = ["noci"], # TODO: determine why this times out on Travis and reenable.
6870
deps = [
6971
":grpc_plugin",
7072
"//opencensus/plugins/internal/testing:echo_proto",

opencensus/stats/examples/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ cc_test(
4040
name = "exporter_example",
4141
srcs = ["exporter_example.cc"],
4242
copts = TEST_COPTS,
43+
tags = ["noci"], # This runs slowly and is not very useful as a test.
4344
deps = [
45+
"//opencensus/stats",
4446
"@com_google_absl//absl/memory",
4547
"@com_google_absl//absl/strings",
4648
"@com_google_absl//absl/time",
47-
"//opencensus/stats",
4849
"@com_google_googletest//:gtest_main",
4950
],
5051
)

0 commit comments

Comments
 (0)