Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit d8ec569

Browse files
authored
Tidy up BUILD files. (#408)
- Explicitly passing -pthread isn't needed anymore. - Don't rely on transitive deps. - Several targets didn't need core_headers.
1 parent 4587b6c commit d8ec569

File tree

7 files changed

+2
-8
lines changed

7 files changed

+2
-8
lines changed

examples/helloworld/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ cc_binary(
2222
name = "helloworld",
2323
srcs = ["helloworld.cc"],
2424
copts = DEFAULT_COPTS,
25-
linkopts = ["-pthread"], # Required for absl/synchronization bits.
2625
deps = [
2726
"//opencensus/exporters/stats/stdout:stdout_exporter",
2827
"//opencensus/exporters/trace/stdout:stdout_exporter",

opencensus/common/internal/BUILD

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ cc_binary(
9898
testonly = 1,
9999
srcs = ["random_benchmark.cc"],
100100
copts = TEST_COPTS,
101-
linkopts = ["-pthread"], # Required for absl/synchronization bits.
102101
linkstatic = 1,
103102
deps = [
104103
":random_lib",
@@ -123,7 +122,6 @@ cc_binary(
123122
testonly = 1,
124123
srcs = ["timestamp_benchmark.cc"],
125124
copts = TEST_COPTS,
126-
#linkopts = ["-pthread"], # Required for absl/synchronization bits.
127125
linkstatic = 1,
128126
deps = [
129127
":timestamp",

opencensus/context/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ cc_binary(
7878
testonly = 1,
7979
srcs = ["internal/context_benchmark.cc"],
8080
copts = TEST_COPTS,
81-
linkopts = ["-pthread"], # Required for absl/synchronization bits.
8281
linkstatic = 1,
8382
deps = [
8483
":context",

opencensus/exporters/trace/ocagent/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ cc_library(
3535
"//opencensus/common/internal/grpc:with_user_agent",
3636
"//opencensus/trace",
3737
"@com_github_grpc_grpc//:grpc++",
38-
"@com_google_absl//absl/base:core_headers",
3938
"@com_google_absl//absl/memory",
4039
"@com_google_absl//absl/strings",
4140
"@com_google_absl//absl/time",

opencensus/exporters/trace/zipkin/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ cc_library(
3434
"//opencensus/trace",
3535
"@com_github_curl//:curl",
3636
"@com_github_tencent_rapidjson//:rapidjson",
37-
"@com_google_absl//absl/base:core_headers",
3837
"@com_google_absl//absl/memory",
3938
"@com_google_absl//absl/strings",
4039
"@com_google_absl//absl/time",

opencensus/stats/BUILD

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@ cc_binary(
252252
testonly = 1,
253253
srcs = ["internal/stats_manager_benchmark.cc"],
254254
copts = TEST_COPTS,
255-
linkopts = ["-pthread"], # Required for absl/synchronization bits.
256255
linkstatic = 1,
257256
deps = [
258257
":core",

opencensus/tags/BUILD

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ cc_library(
3636
deps = [
3737
"@com_google_absl//absl/base:core_headers",
3838
"@com_google_absl//absl/hash",
39+
"@com_google_absl//absl/memory",
3940
"@com_google_absl//absl/strings",
4041
"@com_google_absl//absl/synchronization",
4142
],
@@ -88,6 +89,7 @@ cc_test(
8889
deps = [
8990
":tags",
9091
"@com_google_absl//absl/hash",
92+
"@com_google_absl//absl/strings",
9193
"@com_google_googletest//:gtest_main",
9294
],
9395
)
@@ -135,7 +137,6 @@ cc_binary(
135137
testonly = 1,
136138
srcs = ["internal/with_tag_map_benchmark.cc"],
137139
copts = TEST_COPTS,
138-
linkopts = ["-pthread"], # Required for absl/synchronization bits.
139140
linkstatic = 1,
140141
deps = [
141142
":tags",

0 commit comments

Comments
 (0)