Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Commit fc6f888

Browse files
authored
Updating grpc plugin with OrphanablePtr. (#104)
* Updating grpc byte stream based on changes to grpc repo.
1 parent c8398fa commit fc6f888

File tree

4 files changed

+14
-11
lines changed

4 files changed

+14
-11
lines changed

opencensus/plugins/grpc/internal/client_filter.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ void CensusClientCallData::OnDoneRecvMessageCb(void *user_data,
7373
// Stream messages are no longer valid after receiving trailing metadata.
7474
if ((*calld->recv_message_) != nullptr) {
7575
calld->context_.Span().AddReceivedMessageEvent(
76-
calld->recv_message_count_++, (*calld->recv_message_)->length,
77-
(*calld->recv_message_)->length);
76+
calld->recv_message_count_++, (*calld->recv_message_)->length(),
77+
(*calld->recv_message_)->length());
7878
}
7979
GRPC_CLOSURE_RUN(calld->initial_on_done_recv_message_, GRPC_ERROR_REF(error));
8080
}
@@ -117,8 +117,8 @@ void CensusClientCallData::StartTransportStreamOpBatch(
117117
if (op->send_message() != nullptr) {
118118
context_.Span().AddSentMessageEvent(
119119
sent_message_count_++,
120-
op->op()->payload->send_message.send_message->length,
121-
op->op()->payload->send_message.send_message->length);
120+
op->op()->payload->send_message.send_message->length(),
121+
op->op()->payload->send_message.send_message->length());
122122
}
123123
if (op->recv_message() != nullptr) {
124124
recv_message_ = op->op()->payload->recv_message.recv_message;

opencensus/plugins/grpc/internal/client_filter.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "absl/time/time.h"
2222
#include "opencensus/plugins/grpc/internal/channel_filter.h"
2323
#include "opencensus/plugins/grpc/internal/filter.h"
24+
#include "src/core/lib/gprpp/orphanable.h"
2425

2526
namespace opencensus {
2627

@@ -80,7 +81,7 @@ class CensusClientCallData : public grpc::CallData {
8081
// Server elapsed time in nanoseconds.
8182
uint64_t elapsed_time_;
8283
// The received message--may be null.
83-
grpc_byte_stream **recv_message_; // Not owned.
84+
grpc_core::OrphanablePtr<grpc_core::ByteStream> *recv_message_; // Not owned.
8485
// Number of messages in this RPC.
8586
uint32_t recv_message_count_;
8687
uint32_t sent_message_count_;

opencensus/plugins/grpc/internal/server_filter.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ void CensusServerCallData::OnDoneRecvMessageCb(void *user_data,
7373
// Stream messages are no longer valid after receiving trailing metadata.
7474
if ((*calld->recv_message_) != nullptr) {
7575
calld->context_.Span().AddReceivedMessageEvent(
76-
calld->recv_message_count_++, (*calld->recv_message_)->length,
77-
(*calld->recv_message_)->length);
76+
calld->recv_message_count_++, (*calld->recv_message_)->length(),
77+
(*calld->recv_message_)->length());
7878
}
7979
GRPC_CLOSURE_RUN(calld->initial_on_done_recv_message_, GRPC_ERROR_REF(error));
8080
}
@@ -139,8 +139,8 @@ void CensusServerCallData::StartTransportStreamOpBatch(
139139
if (op->send_message() != nullptr) {
140140
context_.Span().AddSentMessageEvent(
141141
sent_message_count_++,
142-
op->op()->payload->send_message.send_message->length,
143-
op->op()->payload->send_message.send_message->length);
142+
op->op()->payload->send_message.send_message->length(),
143+
op->op()->payload->send_message.send_message->length());
144144
}
145145
if (op->recv_message() != nullptr) {
146146
recv_message_ = op->op()->payload->recv_message.recv_message;

opencensus/plugins/grpc/internal/server_filter.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "include/grpc/grpc_security.h"
2424
#include "opencensus/plugins/grpc/internal/channel_filter.h"
2525
#include "opencensus/plugins/grpc/internal/filter.h"
26+
#include "src/core/lib/gprpp/orphanable.h"
2627

2728
namespace opencensus {
2829

@@ -78,9 +79,10 @@ class CensusServerCallData : public grpc::CallData {
7879
// recv message
7980
grpc_closure *initial_on_done_recv_message_;
8081
grpc_closure on_done_recv_message_;
81-
absl::Time start_time_; // For measuring elapsed time.
82+
absl::Time start_time_;
8283
absl::Duration elapsed_time_;
83-
grpc_byte_stream **recv_message_;
84+
// The received message--may be null.
85+
grpc_core::OrphanablePtr<grpc_core::ByteStream> *recv_message_; // Not owned.
8486
uint32_t recv_message_count_;
8587
uint32_t sent_message_count_;
8688
};

0 commit comments

Comments
 (0)