Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit 7aa5bf8

Browse files
author
Dino Oliva
committed
Updates bytes-based measurements with appropriate units. Also ixes comments.
1 parent 2e123f1 commit 7aa5bf8

File tree

1 file changed

+33
-32
lines changed

1 file changed

+33
-32
lines changed

‎core/java/com/google/instrumentation/stats/RpcConstants.java‎

Lines changed: 33 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ public final class RpcConstants {
4747
public static final MeasurementDescriptor RPC_CLIENT_REQUEST_BYTES =
4848
MeasurementDescriptor.create(
4949
"/rpc/client/request_bytes",
50-
"Request MB/s",
51-
MeasurementUnit.create(6, bytes, seconds));
50+
"Request MB",
51+
MeasurementUnit.create(6, bytes));
5252
public static final MeasurementDescriptor RPC_CLIENT_RESPONSE_BYTES =
5353
MeasurementDescriptor.create(
5454
"/rpc/client/response_bytes",
55-
"Response MB/s",
56-
MeasurementUnit.create(6, bytes, seconds));
55+
"Response MB",
56+
MeasurementUnit.create(6, bytes));
5757
// TODO(dpo): verify this encoding
5858
public static final MeasurementDescriptor RPC_CLIENT_ROUNDTRIP_LATENCY =
5959
MeasurementDescriptor.create(
@@ -69,12 +69,12 @@ public final class RpcConstants {
6969
MeasurementDescriptor.create(
7070
"/rpc/client/uncompressed_request_bytes",
7171
"Uncompressed Request MB/s",
72-
MeasurementUnit.create(6, bytes, seconds));
72+
MeasurementUnit.create(6, bytes));
7373
public static final MeasurementDescriptor RPC_CLIENT_UNCOMPRESSED_RESPONSE_BYTES =
7474
MeasurementDescriptor.create(
7575
"/rpc/client/uncompressed_response_bytes",
76-
"Uncompressed Request MB/s",
77-
MeasurementUnit.create(6, bytes, seconds));
76+
"Uncompressed Request MB",
77+
MeasurementUnit.create(6, bytes));
7878

7979
/**
8080
* Census defined rpc server {@link MeasurementDescriptor}s.
@@ -87,13 +87,13 @@ public final class RpcConstants {
8787
public static final MeasurementDescriptor RPC_SERVER_REQUEST_BYTES =
8888
MeasurementDescriptor.create(
8989
"/rpc/server/request_bytes",
90-
"Request MB/s",
91-
MeasurementUnit.create(6, bytes, seconds));
90+
"Request MB",
91+
MeasurementUnit.create(6, bytes));
9292
public static final MeasurementDescriptor RPC_SERVER_RESPONSE_BYTES =
9393
MeasurementDescriptor.create(
9494
"/rpc/server/response_bytes",
95-
"Response MB/s",
96-
MeasurementUnit.create(6, bytes, seconds));
95+
"Response MB",
96+
MeasurementUnit.create(6, bytes));
9797
public static final MeasurementDescriptor RPC_SERVER_SERVER_ELAPSED_TIME =
9898
MeasurementDescriptor.create(
9999
"/rpc/server/server_elapsed_time",
@@ -107,20 +107,21 @@ public final class RpcConstants {
107107
public static final MeasurementDescriptor RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES =
108108
MeasurementDescriptor.create(
109109
"/rpc/server/uncompressed_request_bytes",
110-
"Uncompressed Request MB/s",
111-
MeasurementUnit.create(6, bytes, seconds));
110+
"Uncompressed Request MB",
111+
MeasurementUnit.create(6, bytes));
112112
public static final MeasurementDescriptor RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES =
113113
MeasurementDescriptor.create(
114114
"/rpc/server/uncompressed_response_bytes",
115-
"Uncompressed Request MB/s",
116-
MeasurementUnit.create(6, bytes, seconds));
115+
"Uncompressed Request MB",
116+
MeasurementUnit.create(6, bytes));
117117

118-
// Common sized histogram bucket boundaries.
119-
private static final List<Double> bytes_bucket_boundaries = Arrays.asList(
118+
// Common histogram bucket boundaries for bytes received/sets DistributionViewDescriptors.
119+
private static final List<Double> BYTES_BUCKET_BOUNDARIES = Arrays.asList(
120120
0.0, 1024.0, 2048.0, 4096.0, 16384.0, 65536.0, 262144.0, 1048576.0, 4194304.0, 16777216.0,
121121
67108864.0, 268435456.0, 1073741824.0, 4294967296.0);
122122

123-
private static final List<Double> millis_bucket_boundaries = Arrays.asList(
123+
// Common histogram bucket boundaries for latency and elapsed-time DistributionViewDescriptors.
124+
private static final List<Double> MILLIS_BUCKET_BOUNDARIES = Arrays.asList(
124125
0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 8.0, 10.0, 13.0, 16.0, 20.0, 25.0, 30.0, 40.0, 50.0,
125126
65.0, 80.0, 100.0, 130.0, 160.0, 200.0, 250.0, 300.0, 400.0, 500.0, 650.0, 800.0, 1000.0,
126127
2000.0, 5000.0, 10000.0, 20000.0, 50000.0, 100000.0);
@@ -140,28 +141,28 @@ public final class RpcConstants {
140141
"rpc client roundtrip latency",
141142
"Latency in msecs",
142143
RPC_CLIENT_ROUNDTRIP_LATENCY,
143-
DistributionAggregationDescriptor.create(millis_bucket_boundaries),
144+
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
144145
Arrays.asList(RPC_CLIENT_METHOD));
145146
public static final DistributionViewDescriptor RPC_CLIENT_SERVER_ELAPSED_TIME_VIEW =
146147
DistributionViewDescriptor.create(
147148
"rpc client server_elapsed_time",
148149
"Server elapsed time in msecs",
149150
RPC_CLIENT_SERVER_ELAPSED_TIME,
150-
DistributionAggregationDescriptor.create(millis_bucket_boundaries),
151+
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
151152
Arrays.asList(RPC_CLIENT_METHOD));
152153
public static final DistributionViewDescriptor RPC_CLIENT_REQUEST_BYTES_VIEW =
153154
DistributionViewDescriptor.create(
154155
"rpc client request_bytes",
155-
"Request MB/s",
156+
"Request MB",
156157
RPC_CLIENT_REQUEST_BYTES,
157-
DistributionAggregationDescriptor.create(bytes_bucket_boundaries),
158+
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
158159
Arrays.asList(RPC_CLIENT_METHOD));
159160
public static final DistributionViewDescriptor RPC_CLIENT_RESPONSE_BYTES_VIEW =
160161
DistributionViewDescriptor.create(
161162
"/rpc/client/response_bytes",
162-
"Response MB/s",
163+
"Response MB",
163164
RPC_CLIENT_RESPONSE_BYTES,
164-
DistributionAggregationDescriptor.create(bytes_bucket_boundaries),
165+
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
165166
Arrays.asList(RPC_CLIENT_METHOD));
166167

167168
/**
@@ -179,40 +180,40 @@ public final class RpcConstants {
179180
"rpc server latency",
180181
"Latency in msecs",
181182
RPC_SERVER_SERVER_LATENCY,
182-
DistributionAggregationDescriptor.create(millis_bucket_boundaries),
183+
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
183184
Arrays.asList(RPC_SERVER_METHOD));
184185
public static final DistributionViewDescriptor RPC_SERVER_SERVER_ELAPSED_TIME_VIEW =
185186
DistributionViewDescriptor.create(
186187
"rpc server elapsed_time",
187188
"Server elapsed time in msecs",
188189
RPC_SERVER_SERVER_ELAPSED_TIME,
189-
DistributionAggregationDescriptor.create(millis_bucket_boundaries),
190+
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
190191
Arrays.asList(RPC_SERVER_METHOD));
191192
public static final DistributionViewDescriptor RPC_SERVER_REQUEST_BYTES_VIEW =
192193
DistributionViewDescriptor.create(
193194
"rpc server request_bytes",
194-
"Request MB/s",
195+
"Request MB",
195196
RPC_SERVER_REQUEST_BYTES,
196-
DistributionAggregationDescriptor.create(bytes_bucket_boundaries),
197+
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
197198
Arrays.asList(RPC_SERVER_METHOD));
198199
public static final DistributionViewDescriptor RPC_SERVER_RESPONSE_BYTES_VIEW =
199200
DistributionViewDescriptor.create(
200201
"/rpc/server/response_bytes",
201-
"Response MB/s",
202+
"Response MB",
202203
RPC_SERVER_RESPONSE_BYTES,
203-
DistributionAggregationDescriptor.create(bytes_bucket_boundaries),
204+
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
204205
Arrays.asList(RPC_SERVER_METHOD));
205206
public static final DistributionViewDescriptor RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES_VIEW =
206207
DistributionViewDescriptor.create(
207208
"/rpc/server/uncompressed_request_bytes",
208-
"Uncompressed Request MB/s",
209+
"Uncompressed Request MB",
209210
RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES,
210211
DistributionAggregationDescriptor.create(),
211212
Arrays.asList(RPC_SERVER_METHOD));
212213
public static final DistributionViewDescriptor RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES_VIEW =
213214
DistributionViewDescriptor.create(
214215
"/rpc/server/uncompressed_response_bytes",
215-
"Uncompressed Request MB/s",
216+
"Uncompressed Request MB",
216217
RPC_SERVER_UNCOMPRESSED_RESPONSE_BYTES,
217218
DistributionAggregationDescriptor.create(),
218219
Arrays.asList(RPC_SERVER_METHOD));

0 commit comments

Comments
 (0)