Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit 7ca44e7

Browse files
committed
Disable setting min/max for Stackdriver export (#829)
* Disable setting min/max for Stackdriver export * Add a TODO in the test (cherry picked from commit d8a88ec)
1 parent 86b751d commit 7ca44e7

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

exporters/stats/stackdriver/src/main/java/io/opencensus/exporter/stats/stackdriver/StackdriverExportUtils.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.google.api.Distribution;
2222
import com.google.api.Distribution.BucketOptions;
2323
import com.google.api.Distribution.BucketOptions.Explicit;
24-
import com.google.api.Distribution.Range;
2524
import com.google.api.LabelDescriptor;
2625
import com.google.api.LabelDescriptor.ValueType;
2726
import com.google.api.Metric;
@@ -278,11 +277,12 @@ static Distribution createDistribution(
278277
.addAllBucketCounts(distributionData.getBucketCounts())
279278
.setCount(distributionData.getCount())
280279
.setMean(distributionData.getMean())
281-
.setRange(
282-
Range.newBuilder()
283-
.setMax(distributionData.getMax())
284-
.setMin(distributionData.getMin())
285-
.build())
280+
// TODO(songya): uncomment this once Stackdriver supports setting max and min.
281+
// .setRange(
282+
// Range.newBuilder()
283+
// .setMax(distributionData.getMax())
284+
// .setMin(distributionData.getMin())
285+
// .build())
286286
.setSumOfSquaredDeviation(distributionData.getSumOfSquaredDeviations())
287287
.build();
288288
}

exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverExportUtilsTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,9 @@ public void createDistribution() {
208208
com.google.api.Distribution.newBuilder()
209209
.setMean(2)
210210
.setCount(3)
211-
.setRange(
212-
com.google.api.Distribution.Range.newBuilder().setMin(0).setMax(5).build())
211+
// TODO(songya): uncomment this once Stackdriver supports setting max and min.
212+
// .setRange(
213+
// com.google.api.Distribution.Range.newBuilder().setMin(0).setMax(5).build())
213214
.setBucketOptions(StackdriverExportUtils.createBucketOptions(BUCKET_BOUNDARIES))
214215
.addAllBucketCounts(Arrays.asList(0L, 1L, 1L, 0L, 1L))
215216
.setSumOfSquaredDeviation(14)

0 commit comments

Comments
 (0)