Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit 8d4372e

Browse files
author
Bogdan Drutu
authored
Add RedundantImport check and upgrade checkstyle to 8.0. (#579)
1 parent 8af5347 commit 8d4372e

File tree

7 files changed

+2
-6
lines changed

7 files changed

+2
-6
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ subprojects {
164164

165165
checkstyle {
166166
configFile = file("$rootDir/buildscripts/checkstyle.xml")
167-
toolVersion = "7.6"
167+
toolVersion = "8.0"
168168
ignoreFailures = false
169169
if (rootProject.hasProperty("checkstyle.ignoreFailures")) {
170170
ignoreFailures = rootProject.properties["checkstyle.ignoreFailures"].toBoolean()

buildscripts/checkstyle.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
5151
</module>
5252
<module name="AvoidStarImport"/>
53+
<module name="RedundantImport"/>
5354
<module name="OneTopLevelClass"/>
5455
<module name="NoLineWrap"/>
5556
<module name="EmptyBlock">

impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020

21-
import io.opencensus.impl.internal.DisruptorEventQueue;
2221
import io.opencensus.implcore.internal.EventQueue;
2322
import org.junit.Test;
2423
import org.junit.runner.RunWith;

impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import io.opencensus.common.Clock;
2323
import io.opencensus.common.Timestamp;
24-
import io.opencensus.implcore.internal.TimestampConverter;
2524
import org.junit.Before;
2625
import org.junit.Test;
2726
import org.junit.runner.RunWith;

impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020

21-
import io.opencensus.implcore.trace.config.TraceConfigImpl;
2221
import io.opencensus.trace.config.TraceParams;
2322
import io.opencensus.trace.samplers.Samplers;
2423
import org.junit.Test;

impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020

21-
import io.opencensus.implcore.trace.internal.ConcurrentIntrusiveList;
2221
import io.opencensus.implcore.trace.internal.ConcurrentIntrusiveList.Element;
2322
import org.junit.Rule;
2423
import org.junit.Test;

impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import io.opencensus.implcore.trace.TracerImpl;
2323
import io.opencensus.implcore.trace.export.ExportComponentImpl;
2424
import io.opencensus.implcore.trace.propagation.PropagationComponentImpl;
25-
import io.opencensus.impllite.trace.TraceComponentImplLite;
2625
import io.opencensus.trace.Tracing;
2726
import org.junit.Test;
2827
import org.junit.runner.RunWith;

0 commit comments

Comments
 (0)