1919import static com .google .common .base .Preconditions .checkNotNull ;
2020
2121import io .opencensus .common .ExperimentalApi ;
22- import io .opencensus .common .Scope ;
2322import io .opencensus .contrib .http .HttpRequestContext ;
2423import io .opencensus .contrib .http .HttpServerHandler ;
25- import io .opencensus .trace .Tracing ;
2624import java .io .Closeable ;
27- import javax .annotation .Nullable ;
2825import javax .servlet .AsyncContext ;
2926import javax .servlet .AsyncEvent ;
3027import javax .servlet .AsyncListener ;
@@ -40,7 +37,6 @@ public final class OcHttpServletListener implements Closeable, AsyncListener {
4037 private final HttpRequestContext context ;
4138 private final HttpServerHandler <HttpServletRequest , HttpServletResponse , HttpServletRequest >
4239 handler ;
43- @ Nullable private Scope scope = null ;
4440
4541 OcHttpServletListener (
4642 HttpServerHandler <HttpServletRequest , HttpServletResponse , HttpServletRequest > handler ,
@@ -60,9 +56,6 @@ public void onComplete(AsyncEvent event) {
6056 if (response instanceof HttpServletResponse ) {
6157 OcHttpServletUtil .recordMessageSentEvent (handler , context , (HttpServletResponse ) response );
6258 }
63- if (scope != null ) {
64- scope .close ();
65- }
6659 handler .handleEnd (
6760 context ,
6861 (HttpServletRequest ) event .getSuppliedRequest (),
@@ -73,9 +66,6 @@ public void onComplete(AsyncEvent event) {
7366
7467 @ Override
7568 public void onError (AsyncEvent event ) {
76- if (scope != null ) {
77- scope .close ();
78- }
7969 handler .handleEnd (
8070 context ,
8171 (HttpServletRequest ) event .getSuppliedRequest (),
@@ -89,16 +79,12 @@ public void onError(AsyncEvent event) {
8979 public void onStartAsync (AsyncEvent event ) {
9080 AsyncContext eventAsyncContext = event .getAsyncContext ();
9181 if (eventAsyncContext != null ) {
92- this .scope = Tracing .getTracer ().withSpan (handler .getSpanFromContext (context ));
9382 eventAsyncContext .addListener (this , event .getSuppliedRequest (), event .getSuppliedResponse ());
9483 }
9584 }
9685
9786 @ Override
9887 public void onTimeout (AsyncEvent event ) {
99- if (scope != null ) {
100- scope .close ();
101- }
10288 handler .handleEnd (
10389 context ,
10490 (HttpServletRequest ) event .getSuppliedRequest (),
0 commit comments