Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Commit f1c31e2

Browse files
author
Dino Oliva
committed
Updates constant names to be more descriptive.
1 parent f974034 commit f1c31e2

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

core/java/com/google/instrumentation/stats/RpcConstants.java

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,12 @@ public final class RpcConstants {
116116
MeasurementUnit.create(6, bytes));
117117

118118
// Common histogram bucket boundaries for bytes received/sets DistributionViewDescriptors.
119-
private static final List<Double> BYTES_BUCKET_BOUNDARIES = Arrays.asList(
119+
private static final List<Double> RPC_BYTES_BUCKET_BOUNDARIES = Arrays.asList(
120120
0.0, 1024.0, 2048.0, 4096.0, 16384.0, 65536.0, 262144.0, 1048576.0, 4194304.0, 16777216.0,
121121
67108864.0, 268435456.0, 1073741824.0, 4294967296.0);
122122

123123
// Common histogram bucket boundaries for latency and elapsed-time DistributionViewDescriptors.
124-
private static final List<Double> MILLIS_BUCKET_BOUNDARIES = Arrays.asList(
124+
private static final List<Double> RPC_MILLIS_BUCKET_BOUNDARIES = Arrays.asList(
125125
0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 8.0, 10.0, 13.0, 16.0, 20.0, 25.0, 30.0, 40.0, 50.0,
126126
65.0, 80.0, 100.0, 130.0, 160.0, 200.0, 250.0, 300.0, 400.0, 500.0, 650.0, 800.0, 1000.0,
127127
2000.0, 5000.0, 10000.0, 20000.0, 50000.0, 100000.0);
@@ -141,28 +141,28 @@ public final class RpcConstants {
141141
"rpc client roundtrip latency",
142142
"Latency in msecs",
143143
RPC_CLIENT_ROUNDTRIP_LATENCY,
144-
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
144+
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
145145
Arrays.asList(RPC_CLIENT_METHOD));
146146
public static final DistributionViewDescriptor RPC_CLIENT_SERVER_ELAPSED_TIME_VIEW =
147147
DistributionViewDescriptor.create(
148148
"rpc client server_elapsed_time",
149149
"Server elapsed time in msecs",
150150
RPC_CLIENT_SERVER_ELAPSED_TIME,
151-
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
151+
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
152152
Arrays.asList(RPC_CLIENT_METHOD));
153153
public static final DistributionViewDescriptor RPC_CLIENT_REQUEST_BYTES_VIEW =
154154
DistributionViewDescriptor.create(
155155
"rpc client request_bytes",
156156
"Request MB",
157157
RPC_CLIENT_REQUEST_BYTES,
158-
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
158+
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
159159
Arrays.asList(RPC_CLIENT_METHOD));
160160
public static final DistributionViewDescriptor RPC_CLIENT_RESPONSE_BYTES_VIEW =
161161
DistributionViewDescriptor.create(
162162
"/rpc/client/response_bytes",
163163
"Response MB",
164164
RPC_CLIENT_RESPONSE_BYTES,
165-
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
165+
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
166166
Arrays.asList(RPC_CLIENT_METHOD));
167167

168168
/**
@@ -180,28 +180,28 @@ public final class RpcConstants {
180180
"rpc server latency",
181181
"Latency in msecs",
182182
RPC_SERVER_SERVER_LATENCY,
183-
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
183+
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
184184
Arrays.asList(RPC_SERVER_METHOD));
185185
public static final DistributionViewDescriptor RPC_SERVER_SERVER_ELAPSED_TIME_VIEW =
186186
DistributionViewDescriptor.create(
187187
"rpc server elapsed_time",
188188
"Server elapsed time in msecs",
189189
RPC_SERVER_SERVER_ELAPSED_TIME,
190-
DistributionAggregationDescriptor.create(MILLIS_BUCKET_BOUNDARIES),
190+
DistributionAggregationDescriptor.create(RPC_MILLIS_BUCKET_BOUNDARIES),
191191
Arrays.asList(RPC_SERVER_METHOD));
192192
public static final DistributionViewDescriptor RPC_SERVER_REQUEST_BYTES_VIEW =
193193
DistributionViewDescriptor.create(
194194
"rpc server request_bytes",
195195
"Request MB",
196196
RPC_SERVER_REQUEST_BYTES,
197-
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
197+
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
198198
Arrays.asList(RPC_SERVER_METHOD));
199199
public static final DistributionViewDescriptor RPC_SERVER_RESPONSE_BYTES_VIEW =
200200
DistributionViewDescriptor.create(
201201
"/rpc/server/response_bytes",
202202
"Response MB",
203203
RPC_SERVER_RESPONSE_BYTES,
204-
DistributionAggregationDescriptor.create(BYTES_BUCKET_BOUNDARIES),
204+
DistributionAggregationDescriptor.create(RPC_BYTES_BUCKET_BOUNDARIES),
205205
Arrays.asList(RPC_SERVER_METHOD));
206206
public static final DistributionViewDescriptor RPC_SERVER_UNCOMPRESSED_REQUEST_BYTES_VIEW =
207207
DistributionViewDescriptor.create(

0 commit comments

Comments
 (0)