Skip to content
This repository was archived by the owner on Oct 3, 2023. It is now read-only.

Commit 20e4cf0

Browse files
authored
Replace assert.equal with assert.strictEqual (#562)
* replace assert.equal with assert.strictEqual * Fix build
1 parent 367db52 commit 20e4cf0

37 files changed

+365
-351
lines changed

packages/opencensus-core/test/test-binary-serializer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ describe('Binary Format Serializer', () => {
109109
0x02, 0x76, 0x32
110110
]);
111111
const tags = deserializeBinary(buff);
112-
assert.equal(tags.tags.size, 1);
112+
assert.strictEqual(tags.tags.size, 1);
113113
assert.deepStrictEqual(tags, expectedTags);
114114
});
115115
});

packages/opencensus-core/test/test-console-logger.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ describe('ConsoleLogger', () => {
3636
describe('new ConsoleLogger()', () => {
3737
it('should log with default levels', () => {
3838
logger.logger();
39-
assert.equal(LEVELS.length, ConsoleLogger.LEVELS.length);
39+
assert.strictEqual(LEVELS.length, ConsoleLogger.LEVELS.length);
4040
});
4141

4242
it('should log with error', () => {
@@ -65,7 +65,7 @@ describe('ConsoleLogger', () => {
6565

6666
const validateString = consoleTxt.indexOf('warn');
6767

68-
assert.equal(validateString, -1);
68+
assert.strictEqual(validateString, -1);
6969
});
7070

7171
it('should not log info', () => {
@@ -75,7 +75,7 @@ describe('ConsoleLogger', () => {
7575

7676
const validateString = consoleTxt.indexOf('info');
7777

78-
assert.equal(validateString, -1);
78+
assert.strictEqual(validateString, -1);
7979
});
8080

8181
it('should not log debug', () => {
@@ -84,7 +84,7 @@ describe('ConsoleLogger', () => {
8484
unhookIntercept();
8585
const validateString = consoleTxt.indexOf('debug');
8686

87-
assert.equal(validateString, -1);
87+
assert.strictEqual(validateString, -1);
8888
});
8989
});
9090

@@ -98,7 +98,7 @@ describe('ConsoleLogger', () => {
9898
unhookIntercept();
9999
const validateString = consoleTxt.indexOf('error');
100100

101-
assert.equal(validateString, -1);
101+
assert.strictEqual(validateString, -1);
102102
});
103103

104104
it('should not log warn', () => {
@@ -108,7 +108,7 @@ describe('ConsoleLogger', () => {
108108

109109
const validateString = consoleTxt.indexOf('warn');
110110

111-
assert.equal(validateString, -1);
111+
assert.strictEqual(validateString, -1);
112112
});
113113

114114
it('should not log info', () => {
@@ -118,7 +118,7 @@ describe('ConsoleLogger', () => {
118118

119119
const validateString = consoleTxt.indexOf('info');
120120

121-
assert.equal(validateString, -1);
121+
assert.strictEqual(validateString, -1);
122122
});
123123

124124
it('should not log debug', () => {
@@ -127,7 +127,7 @@ describe('ConsoleLogger', () => {
127127
unhookIntercept();
128128
const validateString = consoleTxt.indexOf('debug');
129129

130-
assert.equal(validateString, -1);
130+
assert.strictEqual(validateString, -1);
131131
});
132132
});
133133
});

packages/opencensus-core/test/test-cumulative.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('CUMULATIVE', () => {
7373

7474
let metric = instance.getMetric();
7575
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
76-
assert.equal(metric!.timeseries.length, 1);
76+
assert.strictEqual(metric!.timeseries.length, 1);
7777
assert.deepStrictEqual(metric!.timeseries, [{
7878
labelValues: LABEL_VALUES_200,
7979
points: [{value: 1, timestamp: mockedTime}],
@@ -86,7 +86,7 @@ describe('CUMULATIVE', () => {
8686
point1.inc();
8787
metric = instance.getMetric();
8888
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
89-
assert.equal(metric!.timeseries.length, 2);
89+
assert.strictEqual(metric!.timeseries.length, 2);
9090
assert.deepStrictEqual(metric!.timeseries, [
9191
{
9292
labelValues: LABEL_VALUES_200,
@@ -136,7 +136,7 @@ describe('CUMULATIVE', () => {
136136
point.inc();
137137
const metric = instance.getMetric();
138138
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
139-
assert.equal(metric!.timeseries.length, 1);
139+
assert.strictEqual(metric!.timeseries.length, 1);
140140
assert.deepStrictEqual(metric!.timeseries, [{
141141
labelValues: LABEL_VALUES_200,
142142
points: [{value: 1, timestamp: mockedTime}],
@@ -149,7 +149,7 @@ describe('CUMULATIVE', () => {
149149
point.inc(10);
150150
let metric = instance.getMetric();
151151
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
152-
assert.equal(metric!.timeseries.length, 1);
152+
assert.strictEqual(metric!.timeseries.length, 1);
153153
assert.deepStrictEqual(metric!.timeseries, [{
154154
labelValues: LABEL_VALUES_200,
155155
points: [{value: 10, timestamp: mockedTime}],
@@ -160,7 +160,7 @@ describe('CUMULATIVE', () => {
160160
point1.inc(30);
161161
metric = instance.getMetric();
162162
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
163-
assert.equal(metric!.timeseries.length, 1);
163+
assert.strictEqual(metric!.timeseries.length, 1);
164164
assert.deepStrictEqual(metric!.timeseries, [{
165165
labelValues: LABEL_VALUES_200,
166166
points: [{value: 40, timestamp: mockedTime}],
@@ -181,7 +181,7 @@ describe('CUMULATIVE', () => {
181181

182182
const metric = instance.getMetric();
183183
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
184-
assert.equal(metric!.timeseries.length, 1);
184+
assert.strictEqual(metric!.timeseries.length, 1);
185185
assert.deepStrictEqual(
186186
metric!.timeseries, [{
187187
labelValues: [UNSET_LABEL_VALUE],
@@ -202,7 +202,7 @@ describe('CUMULATIVE', () => {
202202
instance.getOrCreateTimeSeries([{value: '400'}, {value: '200'}]);
203203
point1.inc(400);
204204
const metric = instance.getMetric();
205-
assert.equal(metric!.timeseries.length, 1);
205+
assert.strictEqual(metric!.timeseries.length, 1);
206206
});
207207

208208
it('should add constant labels', () => {
@@ -214,8 +214,8 @@ describe('CUMULATIVE', () => {
214214
instance.getOrCreateTimeSeries([{value: '200'}, {value: '400'}]);
215215
point.inc(200);
216216
const metric = instance.getMetric();
217-
assert.equal(metric!.descriptor.type, 5);
218-
assert.equal(metric!.timeseries.length, 1);
217+
assert.strictEqual(metric!.descriptor.type, 5);
218+
assert.strictEqual(metric!.timeseries.length, 1);
219219
assert.deepStrictEqual(metric!.descriptor.labelKeys, [
220220
{key: 'k1', description: 'desc'}, {key: 'k2', description: 'desc'},
221221
{key: 'host', description: 'host'}
@@ -241,7 +241,7 @@ describe('CUMULATIVE', () => {
241241
const metric = instance.getMetric();
242242
assert.deepStrictEqual(metric!.descriptor.labelKeys.length, 3);
243243
assert.deepStrictEqual(metric!.descriptor.type, 5);
244-
assert.equal(metric!.timeseries.length, 1);
244+
assert.strictEqual(metric!.timeseries.length, 1);
245245
assert.deepStrictEqual(
246246
metric!.timeseries, [{
247247
labelValues:
@@ -256,7 +256,7 @@ describe('CUMULATIVE', () => {
256256
point.inc(300);
257257
let metric = instance.getMetric();
258258
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
259-
assert.equal(metric!.timeseries.length, 1);
259+
assert.strictEqual(metric!.timeseries.length, 1);
260260
assert.deepStrictEqual(metric!.timeseries, [{
261261
labelValues: [UNSET_LABEL_VALUE],
262262
points: [{value: 300, timestamp: mockedTime}],
@@ -267,7 +267,7 @@ describe('CUMULATIVE', () => {
267267
point1.inc(400);
268268
metric = instance.getMetric();
269269
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
270-
assert.equal(metric!.timeseries.length, 1);
270+
assert.strictEqual(metric!.timeseries.length, 1);
271271
assert.deepStrictEqual(metric!.timeseries, [{
272272
labelValues: [UNSET_LABEL_VALUE],
273273
points: [{value: 700, timestamp: mockedTime}],
@@ -296,7 +296,7 @@ describe('CUMULATIVE', () => {
296296
point1.inc(10);
297297
let metric = instance.getMetric();
298298
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
299-
assert.equal(metric!.timeseries.length, 2);
299+
assert.strictEqual(metric!.timeseries.length, 2);
300300
instance.clear();
301301
metric = instance.getMetric();
302302
assert.deepStrictEqual(metric, null);

packages/opencensus-core/test/test-derived-cumulative.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ describe('DerivedCumulative', () => {
8181
let metric = instance.getMetric();
8282
assert.notEqual(metric, null);
8383
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
84-
assert.equal(metric!.timeseries.length, 1);
84+
assert.strictEqual(metric!.timeseries.length, 1);
8585
assert.deepStrictEqual(metric!.timeseries, [{
8686
labelValues: LABEL_VALUES_200,
8787
points: [{value: 2, timestamp: mockedTime}],
@@ -99,7 +99,7 @@ describe('DerivedCumulative', () => {
9999

100100
metric = instance.getMetric();
101101
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
102-
assert.equal(metric!.timeseries.length, 2);
102+
assert.strictEqual(metric!.timeseries.length, 2);
103103
assert.deepStrictEqual(metric!.timeseries, [
104104
{
105105
labelValues: LABEL_VALUES_200,
@@ -125,7 +125,7 @@ describe('DerivedCumulative', () => {
125125
const metric = instance.getMetric();
126126
assert.notEqual(metric, null);
127127
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
128-
assert.equal(metric!.timeseries.length, 1);
128+
assert.strictEqual(metric!.timeseries.length, 1);
129129
assert.deepStrictEqual(metric!.timeseries, [{
130130
labelValues: LABEL_VALUES_200,
131131
points: [{value: 45, timestamp: mockedTime}],
@@ -152,7 +152,7 @@ describe('DerivedCumulative', () => {
152152
let metric = instance.getMetric();
153153
assert.notEqual(metric, null);
154154
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
155-
assert.equal(metric!.timeseries.length, 1);
155+
assert.strictEqual(metric!.timeseries.length, 1);
156156
assert.deepStrictEqual(metric!.timeseries, [{
157157
labelValues: LABEL_VALUES_200,
158158
points: [{value: 1, timestamp: mockedTime}],
@@ -163,7 +163,7 @@ describe('DerivedCumulative', () => {
163163
queue.addJob();
164164
queue.addJob();
165165
metric = instance.getMetric();
166-
assert.equal(metric!.timeseries.length, 1);
166+
assert.strictEqual(metric!.timeseries.length, 1);
167167
assert.deepStrictEqual(
168168
metric!.timeseries[0].points, [{value: 4, timestamp: mockedTime}]);
169169
});
@@ -188,7 +188,7 @@ describe('DerivedCumulative', () => {
188188
type: CUMULATIVE_DOUBLE,
189189
labelKeys: LABEL_KEYS
190190
});
191-
assert.equal(metric!.timeseries.length, 1);
191+
assert.strictEqual(metric!.timeseries.length, 1);
192192
assert.deepStrictEqual(metric!.timeseries, [{
193193
labelValues: LABEL_VALUES_200,
194194
points: [{value: 0.7, timestamp: mockedTime}],
@@ -203,7 +203,7 @@ describe('DerivedCumulative', () => {
203203
map.set('key1', 'value1');
204204
let metric = instance.getMetric();
205205
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
206-
assert.equal(metric!.timeseries.length, 1);
206+
assert.strictEqual(metric!.timeseries.length, 1);
207207
assert.deepStrictEqual(metric!.timeseries, [{
208208
labelValues: LABEL_VALUES_200,
209209
points: [{value: 2, timestamp: mockedTime}],
@@ -212,7 +212,7 @@ describe('DerivedCumulative', () => {
212212

213213
map.clear();
214214
metric = instance.getMetric();
215-
assert.equal(metric!.timeseries.length, 1);
215+
assert.strictEqual(metric!.timeseries.length, 1);
216216
assert.deepStrictEqual(metric!.timeseries, [{
217217
labelValues: LABEL_VALUES_200,
218218
points: [{value: 2, timestamp: mockedTime}],
@@ -227,7 +227,7 @@ describe('DerivedCumulative', () => {
227227
const metric = instance.getMetric();
228228
assert.notEqual(metric, null);
229229
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
230-
assert.equal(metric!.timeseries.length, 1);
230+
assert.strictEqual(metric!.timeseries.length, 1);
231231
assert.deepStrictEqual(metric!.timeseries, [{
232232
labelValues: LABEL_VALUES_200,
233233
points: [{value: 1, timestamp: mockedTime}],
@@ -271,7 +271,7 @@ describe('DerivedCumulative', () => {
271271
let metric = instance.getMetric();
272272
assert.notEqual(metric, null);
273273
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
274-
assert.equal(metric!.timeseries.length, 2);
274+
assert.strictEqual(metric!.timeseries.length, 2);
275275
instance.clear();
276276
metric = instance.getMetric();
277277
assert.deepStrictEqual(metric, null);

packages/opencensus-core/test/test-derived-gauge.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe('DerivedGauge', () => {
7979
let metric = instance.getMetric();
8080
assert.notEqual(metric, null);
8181
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
82-
assert.equal(metric!.timeseries.length, 1);
82+
assert.strictEqual(metric!.timeseries.length, 1);
8383
assert.deepStrictEqual(
8484
metric!.timeseries, [{
8585
labelValues: LABEL_VALUES_200,
@@ -101,7 +101,7 @@ describe('DerivedGauge', () => {
101101

102102
metric = instance.getMetric();
103103
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
104-
assert.equal(metric!.timeseries.length, 2);
104+
assert.strictEqual(metric!.timeseries.length, 2);
105105
assert.deepStrictEqual(metric!.timeseries, [
106106
{
107107
labelValues: LABEL_VALUES_200,
@@ -132,7 +132,7 @@ describe('DerivedGauge', () => {
132132
const metric = instance.getMetric();
133133
assert.notEqual(metric, null);
134134
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
135-
assert.equal(metric!.timeseries.length, 1);
135+
assert.strictEqual(metric!.timeseries.length, 1);
136136
assert.deepStrictEqual(
137137
metric!.timeseries, [{
138138
labelValues: LABEL_VALUES_200,
@@ -163,7 +163,7 @@ describe('DerivedGauge', () => {
163163
let metric = instance.getMetric();
164164
assert.notEqual(metric, null);
165165
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
166-
assert.equal(metric!.timeseries.length, 1);
166+
assert.strictEqual(metric!.timeseries.length, 1);
167167
assert.deepStrictEqual(
168168
metric!.timeseries, [{
169169
labelValues: LABEL_VALUES_200,
@@ -178,7 +178,7 @@ describe('DerivedGauge', () => {
178178
queue.addJob();
179179
queue.addJob();
180180
metric = instance.getMetric();
181-
assert.equal(metric!.timeseries.length, 1);
181+
assert.strictEqual(metric!.timeseries.length, 1);
182182
assert.deepStrictEqual(
183183
metric!.timeseries[0].points, [{
184184
value: 4,
@@ -207,7 +207,7 @@ describe('DerivedGauge', () => {
207207
type: GAUGE_DOUBLE,
208208
labelKeys: LABEL_KEYS
209209
});
210-
assert.equal(metric!.timeseries.length, 1);
210+
assert.strictEqual(metric!.timeseries.length, 1);
211211
assert.deepStrictEqual(
212212
metric!.timeseries, [{
213213
labelValues: LABEL_VALUES_200,
@@ -239,7 +239,7 @@ describe('DerivedGauge', () => {
239239
type: GAUGE_DOUBLE,
240240
labelKeys: [...LABEL_KEYS, ...Array.from(CONSTANT_LABELS.keys())]
241241
});
242-
assert.equal(metric!.timeseries.length, 1);
242+
assert.strictEqual(metric!.timeseries.length, 1);
243243
assert.deepStrictEqual(
244244
metric!.timeseries, [{
245245
labelValues:
@@ -259,7 +259,7 @@ describe('DerivedGauge', () => {
259259
const metric = instance.getMetric();
260260
assert.notEqual(metric, null);
261261
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
262-
assert.equal(metric!.timeseries.length, 1);
262+
assert.strictEqual(metric!.timeseries.length, 1);
263263
assert.deepStrictEqual(
264264
metric!.timeseries, [{
265265
labelValues: LABEL_VALUES_200,
@@ -305,7 +305,7 @@ describe('DerivedGauge', () => {
305305
let metric = instance.getMetric();
306306
assert.notEqual(metric, null);
307307
assert.deepStrictEqual(metric!.descriptor, expectedMetricDescriptor);
308-
assert.equal(metric!.timeseries.length, 2);
308+
assert.strictEqual(metric!.timeseries.length, 2);
309309
instance.clear();
310310
metric = instance.getMetric();
311311
assert.deepStrictEqual(metric, null);

0 commit comments

Comments
 (0)