This repository was archived by the owner on Oct 3, 2023. It is now read-only.
Commit 90ec78f
Make NullTracer pass spanOptions to constructor (#202)
Pass spanOptions through to the newly created Span instead of always using
default values.
The Span constructor does additional work if there's no options passed in.
Instrumented code that uses the NullTracer (as a result of not sampling or
other reasons) can avoid this work by passing the options that are already
set.
This change also makes the use of the stackTrace option more consistent. It
preserves the passed-in stackTrace, which may be pre-filtered or an empty array.
The current behavior leads to the unexpected outcome that the non-sampled
requests were taking deubg_backtraces when the instrumented route was passing
in its own value.1 parent 39585f2 commit 90ec78f
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| |||
0 commit comments