Add support to initialize azure exporters with proxies (#902)

Author: skinamdar

contrib/opencensus-ext-azure/CHANGELOG.md

@@ -4,6 +4,8 @@
 
 - Change default path of local storage
   ([#903](https://github.com/census-instrumentation/opencensus-python/pull/903))
+- Add support to initialize azure exporters with proxies
+  ([#902](https://github.com/census-instrumentation/opencensus-python/pull/902))
 
 ## 1.0.1
 Released 2019-11-26

contrib/opencensus-ext-azure/opencensus/ext/azure/common/__init__.py

@@ -56,6 +56,9 @@ def process_options(options):
                 TEMPDIR_PREFIX + TEMPDIR_SUFFIX
             )
 
+    if options.proxies is None:
+        options.proxies = '{}'
+
 
 def parse_connection_string(connection_string):
     if connection_string is None:
@@ -105,7 +108,7 @@ def __init__(self, *args, **kwargs):
         logging_sampling_rate=1.0,
         max_batch_size=100,
         minimum_retry_interval=60,  # minimum retry interval in seconds
-        proxy=None,
+        proxies=None,  # string maps url schemes to the url of the proxies
         storage_maintenance_period=60,
         storage_max_size=50*1024*1024,  # 50MiB
         storage_path=None,

contrib/opencensus-ext-azure/opencensus/ext/azure/common/transport.py

@@ -52,6 +52,7 @@ def _transmit(self, envelopes):
                     'Content-Type': 'application/json; charset=utf-8',
                 },
                 timeout=self.options.timeout,
+                proxies=json.loads(self.options.proxies),
             )
         except requests.Timeout:
             logger.warning(

contrib/opencensus-ext-azure/tests/test_azure_log_exporter.py

@@ -85,6 +85,17 @@ def test_invalid_sampling_rate(self):
                 logging_sampling_rate=4.0,
             )
 
+    def test_init_handler_with_proxies(self):
+        handler = log_exporter.AzureLogHandler(
+            instrumentation_key='12345678-1234-5678-abcd-12345678abcd',
+            proxies='{"https":"https://test-proxy.com"}',
+        )
+
+        self.assertEqual(
+            handler.options.proxies,
+            '{"https":"https://test-proxy.com"}',
+        )
+
     @mock.patch('requests.post', return_value=mock.Mock())
     def test_exception(self, requests_mock):
         logger = logging.getLogger(self.id())

contrib/opencensus-ext-azure/tests/test_azure_trace_exporter.py

@@ -45,6 +45,17 @@ def test_ctor(self):
         self.assertRaises(ValueError, lambda: trace_exporter.AzureExporter())
         Options._default.instrumentation_key = instrumentation_key
 
+    def test_init_exporter_with_proxies(self):
+        exporter = trace_exporter.AzureExporter(
+            instrumentation_key='12345678-1234-5678-abcd-12345678abcd',
+            proxies='{"https":"https://test-proxy.com"}',
+        )
+
+        self.assertEqual(
+            exporter.options.proxies,
+            '{"https":"https://test-proxy.com"}',
+        )
+
     @mock.patch('requests.post', return_value=mock.Mock())
     def test_emit_empty(self, request_mock):
         exporter = trace_exporter.AzureExporter(

contrib/opencensus-ext-azure/tests/test_options.py

@@ -90,6 +90,24 @@ def test_process_options_endpoint_default(self):
         self.assertEqual(options.endpoint,
                          'https://dc.services.visualstudio.com/v2/track')
 
+    def test_process_options_proxies_default(self):
+        options = common.Options()
+        options.proxies = "{}"
+        common.process_options(options)
+
+        self.assertEqual(options.proxies, "{}")
+
+    def test_process_options_proxies_set_proxies(self):
+        options = common.Options()
+        options.connection_string = None
+        options.proxies = '{"https": "https://test-proxy.com"}'
+        common.process_options(options)
+
+        self.assertEqual(
+            options.proxies,
+            '{"https": "https://test-proxy.com"}'
+        )
+
     def test_parse_connection_string_none(self):
         cs = None
         result = common.parse_connection_string(cs)