Disable heartbeat metrics in azure exporters (#984)

Author: lzchen

contrib/opencensus-ext-azure/CHANGELOG.md

@@ -12,6 +12,8 @@
   ([#946](https://github.com/census-instrumentation/opencensus-python/pull/946))
 - Added queue capacity configuration for exporters
   ([#949](https://github.com/census-instrumentation/opencensus-python/pull/949))
+- Disable heartbeat metrics in exporters
+  ([#984](https://github.com/census-instrumentation/opencensus-python/pull/984))
 
 ## 1.0.4
 Released 2020-06-29

contrib/opencensus-ext-azure/opencensus/ext/azure/log_exporter/__init__.py

@@ -30,7 +30,6 @@
 )
 from opencensus.ext.azure.common.storage import LocalFileStorage
 from opencensus.ext.azure.common.transport import TransportMixin
-from opencensus.ext.azure.metrics_exporter import heartbeat_metrics
 from opencensus.trace import execution_context
 
 logger = logging.getLogger(__name__)
@@ -60,8 +59,6 @@ def __init__(self, **options):
         self._queue = Queue(capacity=self.options.queue_capacity)
         self._worker = Worker(self._queue, self)
         self._worker.start()
-        heartbeat_metrics.enable_heartbeat_metrics(
-            self.options.connection_string, self.options.instrumentation_key)
 
     def _export(self, batch, event=None):  # pragma: NO COVER
         try:

contrib/opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/__init__.py

@@ -153,9 +153,4 @@ def new_metrics_exporter(**options):
                                     producers,
                                     exporter,
                                     interval=exporter.options.export_interval)
-    from opencensus.ext.azure.metrics_exporter import heartbeat_metrics
-    heartbeat_metrics.enable_heartbeat_metrics(
-        exporter.options.connection_string,
-        exporter.options.instrumentation_key
-    )
     return exporter

contrib/opencensus-ext-azure/opencensus/ext/azure/trace_exporter/__init__.py

@@ -28,7 +28,6 @@
 )
 from opencensus.ext.azure.common.storage import LocalFileStorage
 from opencensus.ext.azure.common.transport import TransportMixin
-from opencensus.ext.azure.metrics_exporter import heartbeat_metrics
 from opencensus.trace.span import SpanKind
 
 try:
@@ -60,8 +59,6 @@ def __init__(self, **options):
         self._telemetry_processors = []
         super(AzureExporter, self).__init__(**options)
         atexit.register(self._stop, self.options.grace_period)
-        heartbeat_metrics.enable_heartbeat_metrics(
-            self.options.connection_string, self.options.instrumentation_key)
 
     def span_data_to_envelope(self, sd):
         envelope = Envelope(

contrib/opencensus-ext-azure/tests/test_azure_metrics_exporter.py

@@ -234,6 +234,7 @@ def test_new_metrics_exporter_no_standard_metrics(self, exporter_mock):
             self.assertFalse(isinstance(exporter_mock.call_args[0][0][0],
                                         producer_class))
 
+    @unittest.skip("Skip because disabling heartbeat metrics")
     @mock.patch('opencensus.ext.azure.metrics_exporter'
                 '.transport.get_exporter_thread')
     def test_new_metrics_exporter_heartbeat(self, exporter_mock):