Tracing: Add Double/Float64 Attribute. (#518)

* Tracing: Add Double/Float64 Attribute.

* Fix test coverage.

* Revert commented changes.

Author: songy23

opencensus/trace/attributes.py

@@ -24,6 +24,8 @@ def _format_attribute_value(value):
     elif isinstance(value, six.string_types):
         value_type = 'string_value'
         value = utils._get_truncatable_str(value)
+    elif isinstance(value, float):
+        value_type = 'double_value'
     else:
         return None
 
@@ -36,7 +38,8 @@ class Attributes(object):
     :type attributes: dict
     :param attributes: The set of attributes. Each attribute's key can be up
                        to 128 bytes long. The value can be a string up to 256
-                       bytes, an integer, or the Boolean values true and false.
+                       bytes, an integer, a floating-point number, or the
+                       Boolean values true and false.
     """
     def __init__(self, attributes=None):
         self.attributes = attributes or {}

opencensus/trace/exporters/jaeger_exporter.py

@@ -312,6 +312,11 @@ def _convert_attribute_to_tag(key, attr):
             key=key,
             vLong=attr,
             vType=jaeger.TagType.LONG)
+    if isinstance(attr, float):
+        return jaeger.Tag(
+            key=key,
+            vDouble=attr,
+            vType=jaeger.TagType.DOUBLE)
     logging.warn('Could not serialize attribute \
             {}:{} to tag'.format(key, attr))
     return None

opencensus/trace/exporters/ocagent/utils.py

@@ -201,7 +201,7 @@ def add_proto_attribute_value(
         pb_attributes,
         attribute_key,
         attribute_value):
-    """Sets string, int or boolean value on protobuf
+    """Sets string, int, boolean or float value on protobuf
         span, link or annotation attributes.
 
     :type pb_attributes:

opencensus/trace/exporters/zipkin_exporter.py

@@ -187,7 +187,7 @@ def _extract_tags_from_span(attr):
         return {}
     tags = {}
     for attribute_key, attribute_value in attr.items():
-        if isinstance(attribute_value, (int, bool)):
+        if isinstance(attribute_value, (int, bool, float)):
             value = str(attribute_value)
         elif isinstance(attribute_value, str):
             res, _ = check_str_length(str_to_check=attribute_value)

tests/unit/trace/exporters/test_jaeger_exporter.py

@@ -180,13 +180,16 @@ def test_translate_to_jaeger(self):
         span_attributes = {
             'key_bool': False,
             'key_string': 'hello_world',
-            'key_int': 3
+            'key_int': 3,
+            'key_double': 111.22,
+            'key_unsupported_type': ()
         }
 
         annotation_attributes = {
             'annotation_bool': True,
             'annotation_string': 'annotation_test',
-            'key_float': .3
+            'key_float': .3,
+            'key_unsupported_type': {}
         }
 
         link_attributes = {'key_bool': True}
@@ -319,6 +322,10 @@ def test_translate_to_jaeger(self):
                         vStr='hello_world'),
                     jaeger.Tag(
                         key='key_int', vType=jaeger.TagType.LONG, vLong=3),
+                    jaeger.Tag(
+                        key='key_double',
+                        vType=jaeger.TagType.DOUBLE,
+                        vDouble=111.22),
                     jaeger.Tag(
                         key='status.code',
                         vType=jaeger.TagType.LONG,
@@ -357,6 +364,10 @@ def test_translate_to_jaeger(self):
                                 key='annotation_string',
                                 vType=jaeger.TagType.STRING,
                                 vStr='annotation_test'),
+                            jaeger.Tag(
+                                key='key_float',
+                                vType=jaeger.TagType.DOUBLE,
+                                vDouble=0.3),
                             jaeger.Tag(
                                 key='message',
                                 vType=jaeger.TagType.STRING,

tests/unit/trace/exporters/test_stackdriver_exporter.py

@@ -159,6 +159,11 @@ def test_translate_to_stackdriver(self, mr_mock):
                         'value': 'value'
                     }
                 },
+                'key_double': {
+                    'double_value': {
+                        'value': 123.45
+                    }
+                },
                 'http.host': {
                     'string_value': {
                         'truncated_byte_count': 0,
@@ -224,6 +229,11 @@ def test_translate_to_stackdriver(self, mr_mock):
                             'value': 'value'
                         }
                     },
+                    'key_double': {
+                        'double_value': {
+                            'value': 123.45
+                        }
+                    },
                     '/http/host': {
                         'string_value': {
                             'truncated_byte_count': 0,

tests/unit/trace/exporters/test_zipkin_exporter.py

@@ -138,7 +138,6 @@ def test_translate_to_zipkin_span_kind_none(self):
                 attributes={
                     'test_key': False,
                     'test_key2': 'raw_value',
-                    # these tags are malformed and should be omitted
                     'test_key3': 0.1,
                 },
                 start_time='2017-08-15T18:02:26.071158Z',
@@ -207,7 +206,8 @@ def test_translate_to_zipkin_span_kind_none(self):
                 'localEndpoint': local_endpoint_ipv6,
                 'tags': {
                     'test_key': 'False',
-                    'test_key2': 'raw_value'
+                    'test_key2': 'raw_value',
+                    'test_key3': '0.1'
                 },
                 'kind': 'SERVER',
                 'annotations': [],
@@ -299,7 +299,6 @@ def test_translate_to_zipkin_with_annotations(self):
                 attributes={
                     'test_key': False,
                     'test_key2': 'raw_value',
-                    # these tags are malformed and should be omitted
                     'test_key3': 0.1,
                 },
                 start_time='2017-08-15T18:02:26.071158Z',
@@ -394,7 +393,8 @@ def test_translate_to_zipkin_with_annotations(self):
                 local_endpoint_ipv6,
                 'tags': {
                     'test_key': 'False',
-                    'test_key2': 'raw_value'
+                    'test_key2': 'raw_value',
+                    'test_key3': '0.1'
                 },
                 'kind':
                 'SERVER',
@@ -422,7 +422,7 @@ def test_translate_to_zipkin_with_annotations(self):
         self.assertEqual(zipkin_spans_ipv6, expected_zipkin_spans_ipv6)
 
     def test_ignore_incorrect_spans(self):
-        attributes = {'float_value': 0.1}
+        attributes = {'unknown_value': {}}
         self.assertEqual(
             zipkin_exporter._extract_tags_from_span(attributes), {})
 

tests/unit/trace/test_attributes.py

@@ -59,6 +59,7 @@ def test_format_attributes_json(self):
             'key1': 'test string',
             'key2': True,
             'key3': 100,
+            'key4': 123.456,
         }
 
         attributes = attributes_module.Attributes(attrs)
@@ -77,6 +78,9 @@ def test_format_attributes_json(self):
                 },
                 'key3': {
                     'int_value': 100
+                },
+                'key4': {
+                    'double_value': 123.456
                 }
             }
         }