Fix TypeError when local file storage is above max limit in opencensus-ext-azure (#1114)

Author: tephe

contrib/opencensus-ext-azure/opencensus/ext/azure/common/storage.py

@@ -196,7 +196,7 @@ def _check_storage_size(self):
                     if size >= self.max_size:
                         logger.warning(
                             "Persistent storage max capacity has been "
-                            "reached. Currently at %fKB. Telemetry will be "
+                            "reached. Currently at %sKB. Telemetry will be "
                             "lost. Please consider increasing the value of "
                             "'storage_max_size' in exporter config.",
                             format(size/1024)

contrib/opencensus-ext-azure/tests/test_storage.py

@@ -151,6 +151,16 @@ def test_check_storage_size_error(self):
                     os_mock.return_value = True
                 self.assertTrue(stor._check_storage_size())
 
+    def test_check_storage_size_above_max_limit(self):
+        input = (1, 2, 3)
+        with LocalFileStorage(os.path.join(TEST_FOLDER, 'asd5'), 1) as stor:
+            with mock.patch('os.path.getsize') as os_mock:
+                os_mock.return_value = 52000000
+                stor.put(input)
+                with mock.patch('os.path.islink') as os_mock:
+                    os_mock.return_value = True
+                self.assertFalse(stor._check_storage_size())
+
     def test_maintenance_routine(self):
         with mock.patch('os.makedirs') as m:
             LocalFileStorage(os.path.join(TEST_FOLDER, 'baz'))