Add storage existence checks (#1150)

Author: lzchen

contrib/opencensus-ext-azure/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Add storage existence checks to storing and transmitting in exporter
+([#1150](https://github.com/census-instrumentation/opencensus-python/pull/1150))
+
 ## 1.1.6
 Released 2022-08-03
 

contrib/opencensus-ext-azure/opencensus/ext/azure/log_exporter/__init__.py

@@ -79,17 +79,19 @@ def _export(self, batch, event=None):  # pragma: NO COVER
                 envelopes = self.apply_telemetry_processors(envelopes)
                 result = self._transmit(envelopes)
                 # Only store files if local storage enabled
-                if self.storage and result is TransportStatusCode.RETRY:
-                    self.storage.put(
-                        envelopes,
-                        self.options.minimum_retry_interval,
-                    )
-            if event:
-                if isinstance(event, QueueExitEvent):
-                    self._transmit_from_storage()  # send files before exit
-                return
-            if len(batch) < self.options.max_batch_size:
-                self._transmit_from_storage()
+                if self.storage:
+                    if result is TransportStatusCode.RETRY:
+                        self.storage.put(
+                            envelopes,
+                            self.options.minimum_retry_interval,
+                        )
+                    if result is TransportStatusCode.SUCCESS:
+                        if len(batch) < self.options.max_batch_size:
+                            self._transmit_from_storage()
+                    if event:
+                        if isinstance(event, QueueExitEvent):
+                            # send files before exit
+                            self._transmit_from_storage()
         finally:
             if event:
                 event.set()

contrib/opencensus-ext-azure/opencensus/ext/azure/metrics_exporter/__init__.py

@@ -81,13 +81,14 @@ def export_metrics(self, metrics):
                 statsbeat.shutdown_statsbeat_metrics()
                 return
             # Only store files if local storage enabled
-            if self.storage and result is TransportStatusCode.RETRY:
-                self.storage.put(batch, self.options.minimum_retry_interval)
-
-        # If there is still room to transmit envelopes, transmit from storage
-        # if available
-        if len(envelopes) < self.options.max_batch_size:
-            self._transmit_from_storage()
+            if self.storage:
+                if result is TransportStatusCode.RETRY:
+                    self.storage.put(batch, self.options.minimum_retry_interval)  # noqa: E501
+                if result is TransportStatusCode.SUCCESS:
+                    # If there is still room to transmit envelopes,
+                    # transmit from storage if available
+                    if len(envelopes) < self.options.max_batch_size:
+                        self._transmit_from_storage()
 
     def metric_to_envelopes(self, metric):
         envelopes = []

contrib/opencensus-ext-azure/opencensus/ext/azure/trace_exporter/__init__.py

@@ -213,11 +213,11 @@ def emit(self, batch, event=None):
                         self.options.minimum_retry_interval
                     )
             if event:
-                if isinstance(event, QueueExitEvent):
+                if self.storage and isinstance(event, QueueExitEvent):
                     self._transmit_from_storage()  # send files before exit
                 event.set()
                 return
-            if len(batch) < self.options.max_batch_size:
+            if self.storage and len(batch) < self.options.max_batch_size:
                 self._transmit_from_storage()
         except Exception:
             logger.exception('Exception occurred while exporting the data.')