added debug output on demand; active for tests

Author: KaiSchwarz-cnic

MYMETA.json

@@ -32,6 +32,7 @@
       },
       "runtime" : {
          "requires" : {
+            "Data::Dumper" : "2.161",
             "LWP::UserAgent" : "6.35",
             "MIME::Base64" : "0",
             "Time::Local" : "0"

MYMETA.yml

@@ -22,6 +22,7 @@ no_index:
     - t
     - inc
 requires:
+  Data::Dumper: '2.161'
   LWP::UserAgent: '6.35'
   MIME::Base64: '0'
   Time::Local: '0'

Makefile

@@ -17,7 +17,7 @@
 #     CONFIGURE_REQUIRES => {  }
 #     LICENSE => q[mit]
 #     NAME => q[WebService::Hexonet::Connector]
-#     PREREQ_PM => { LWP::UserAgent=>q[6.35], MIME::Base64=>q[0], Scalar::Util=>q[0], Test::Exception=>q[0.43], Test::More=>q[0], Test::RequiresInternet=>q[0.05], Time::Local=>q[0] }
+#     PREREQ_PM => { Data::Dumper=>q[2.161], LWP::UserAgent=>q[6.35], MIME::Base64=>q[0], Scalar::Util=>q[0], Test::Exception=>q[0.43], Test::More=>q[0], Test::RequiresInternet=>q[0.05], Time::Local=>q[0] }
 #     TEST_REQUIRES => { Scalar::Util=>q[0], Test::Exception=>q[0.43], Test::More=>q[0], Test::RequiresInternet=>q[0.05] }
 #     VERSION_FROM => q[lib/WebService/Hexonet/Connector.pm]
 
@@ -523,6 +523,7 @@ metafile : create_distdir
 	$(NOECHO) $(ECHO) '    - t' >> META_new.yml
 	$(NOECHO) $(ECHO) '    - inc' >> META_new.yml
 	$(NOECHO) $(ECHO) 'requires:' >> META_new.yml
+	$(NOECHO) $(ECHO) '  Data::Dumper: '\''2.161'\''' >> META_new.yml
 	$(NOECHO) $(ECHO) '  LWP::UserAgent: '\''6.35'\''' >> META_new.yml
 	$(NOECHO) $(ECHO) '  MIME::Base64: '\''0'\''' >> META_new.yml
 	$(NOECHO) $(ECHO) '  Time::Local: '\''0'\''' >> META_new.yml
@@ -564,6 +565,7 @@ metafile : create_distdir
 	$(NOECHO) $(ECHO) '      },' >> META_new.json
 	$(NOECHO) $(ECHO) '      "runtime" : {' >> META_new.json
 	$(NOECHO) $(ECHO) '         "requires" : {' >> META_new.json
+	$(NOECHO) $(ECHO) '            "Data::Dumper" : "2.161",' >> META_new.json
 	$(NOECHO) $(ECHO) '            "LWP::UserAgent" : "6.35",' >> META_new.json
 	$(NOECHO) $(ECHO) '            "MIME::Base64" : "0",' >> META_new.json
 	$(NOECHO) $(ECHO) '            "Time::Local" : "0"' >> META_new.json
@@ -869,6 +871,7 @@ ppd :
 	$(NOECHO) $(ECHO) '    <ABSTRACT>Connector library for the insanely fast L&lt;HEXONET Backend API|https://www.hexonet.net/&gt;.</ABSTRACT>' >> WebService-Hexonet-Connector.ppd
 	$(NOECHO) $(ECHO) '    <AUTHOR>hexonet &lt;[email protected]&gt;</AUTHOR>' >> WebService-Hexonet-Connector.ppd
 	$(NOECHO) $(ECHO) '    <IMPLEMENTATION>' >> WebService-Hexonet-Connector.ppd
+	$(NOECHO) $(ECHO) '        <REQUIRE NAME="Data::Dumper" VERSION="2.161" />' >> WebService-Hexonet-Connector.ppd
 	$(NOECHO) $(ECHO) '        <REQUIRE NAME="LWP::UserAgent" VERSION="6.35" />' >> WebService-Hexonet-Connector.ppd
 	$(NOECHO) $(ECHO) '        <REQUIRE NAME="MIME::Base64" />' >> WebService-Hexonet-Connector.ppd
 	$(NOECHO) $(ECHO) '        <REQUIRE NAME="Time::Local" />' >> WebService-Hexonet-Connector.ppd

Makefile.PL

@@ -7,7 +7,8 @@ WriteMakefile(
     PREREQ_PM    => {
         'LWP::UserAgent' => 6.35,
         'Time::Local'    => 0,
-        'MIME::Base64'   => 0
+        'MIME::Base64'   => 0,
+        'Data::Dumper'   => 2.161
     },
     TEST_REQUIRES => {
         'Test::More'             => 0,

lib/WebService/Hexonet/Connector/Connection.pm

@@ -5,6 +5,7 @@ use warnings;
 use WebService::Hexonet::Connector::Response;
 use WebService::Hexonet::Connector::Util;
 use LWP::UserAgent;
+use Data::Dumper;
 
 our $VERSION = '1.09';
 
@@ -16,9 +17,20 @@ sub new {
         delete $self->{$key};
         $self->{ lc $key } = $value;
     }
+    $self->{"debugMode"} = 0;
     return bless $self, $class;
 }
 
+sub enableDebugMode {
+    my $self = shift;
+    $self->{"debugMode"} = 1;
+}
+
+sub disableDebugMode {
+    my $self = shift;
+    $self->{"debugMode"} = 0;
+}
+
 sub call {
     my $self    = shift;
     my $command = shift;
@@ -70,16 +82,25 @@ sub call_raw_http {
             $post->{s_user} = $config->{user};
         }
     }
-
     my $r = $self->{_useragent}->post( $url, $post );
     if ( $r->is_success ) {
-        return $r->decoded_content;
+        $r = $r->decoded_content;
     }
-    my $err = $r->status_line;
-    return ("[RESPONSE]\r\n"
+    else {
+        my $err = $r->status_line;
+        $r =
+            "[RESPONSE]\r\n"
           . "CODE=421\r\n"
           . "DESCRIPTION=HTTP communication failed;$err\r\n"
-          . "EOF\r\n" );
+          . "EOF\r\n";
+
+    }
+    if ( $self->{"debugMode"} ) {
+        print STDERR Dumper($command);
+        print STDERR Dumper($post);
+        print STDERR Dumper($r);
+    }
+    return $r;
 }
 
 sub _get_useragent {

t/Hexonet-connector.t

@@ -12,7 +12,6 @@ our $VERSION = '1.09';
 ##########################
 
 # T1-5: test import modules
-use_ok( "lib",                                      qw(./lib) );
 use_ok( "Scalar::Util",                             qw(blessed) );
 use_ok( "WebService::Hexonet::Connector",           $VERSION );
 use_ok( "WebService::Hexonet::Connector::Response", $VERSION );
@@ -27,6 +26,7 @@ our $api = WebService::Hexonet::Connector::connect(
         password => 'test.passw0rd'
     }
 );
+$api->enableDebugMode();
 our $cl = blessed($api);
 is(
     $cl,
@@ -59,6 +59,7 @@ $api = WebService::Hexonet::Connector::connect(
         role     => 'testrole'
     }
 );
+$api->enableDebugMode();
 $cl = blessed($api);
 is(
     $cl,
@@ -95,6 +96,7 @@ $api = WebService::Hexonet::Connector::connect(
         role => 'testrole'
     }
 );
+$api->enableDebugMode();
 $cl = blessed($api);
 is(
     $cl,
@@ -123,6 +125,7 @@ $api = WebService::Hexonet::Connector::connect(
     }
 );
 $cl = blessed($api);
+$api->enableDebugMode();
 
 #T11
 is(
@@ -191,6 +194,7 @@ $api = WebService::Hexonet::Connector::connect(
         entity   => "1234"
     }
 );
+$api->enableDebugMode();
 $r = $api->call(
     {
         COMMAND => "QueryDomainList",
@@ -243,6 +247,7 @@ $api = WebService::Hexonet::Connector::connect(
         entity   => "1234"
     }
 );
+$api->enableDebugMode();
 $r = $api->call(
     {
         COMMAND => "QueryDomainPendingDeleteList",