Skip to content

Commit 3d21234

Browse files
authored
Merge pull request #283 from iPraveenParihar/typo/fix-isRbdDriver
fix: correct typo RdbDriver to isRbdDriver
2 parents b6415af + 5fbf2cf commit 3d21234

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

internal/controller/driver_controller.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ func (r *driverReconcile) reconcile() error {
238238
r.reconcileLivenessService,
239239
}
240240

241-
if r.isRdbDriver() {
241+
if r.isRbdDriver() {
242242
reconcilers = append(reconcilers, r.reconcileNodePluginDeamonSetForCsiAddons)
243243
}
244244

@@ -561,7 +561,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error {
561561

562562
// TODO: Move the Topology field from NodePlugin to Driver.Spec
563563
nodePluginSpec := cmp.Or(r.driver.Spec.NodePlugin, &csiv1.NodePluginSpec{})
564-
topology := r.isRdbDriver() && nodePluginSpec.Topology != nil
564+
topology := r.isRbdDriver() && nodePluginSpec.Topology != nil
565565

566566
deploy.Spec = appsv1.DeploymentSpec{
567567
Replicas: pluginSpec.Replicas,
@@ -642,7 +642,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error {
642642
if r.driver.Spec.Encryption != nil {
643643
mounts = append(mounts, utils.KmsConfigVolumeMount)
644644
}
645-
if r.isRdbDriver() {
645+
if r.isRbdDriver() {
646646
mounts = append(mounts, utils.OidcTokenVolumeMount)
647647
}
648648
if logRotationEnabled {
@@ -671,7 +671,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error {
671671
utils.DefaultFsTypeContainerArg,
672672
utils.PreventVolumeModeConversionContainerArg,
673673
utils.HonorPVReclaimPolicyContainerArg,
674-
utils.If(r.isRdbDriver(), utils.DefaultFsTypeContainerArg, ""),
674+
utils.If(r.isRbdDriver(), utils.DefaultFsTypeContainerArg, ""),
675675
utils.TopologyContainerArg(topology),
676676
utils.If(!r.isNfsDriver(), utils.ExtraCreateMetadataContainerArg, ""),
677677
),
@@ -720,7 +720,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error {
720720
utils.LogVerbosityContainerArg(logVerbosity),
721721
utils.CsiAddressContainerArg,
722722
utils.TimeoutContainerArg(grpcTimeout),
723-
utils.If(r.isRdbDriver(), utils.DefaultFsTypeContainerArg, ""),
723+
utils.If(r.isRbdDriver(), utils.DefaultFsTypeContainerArg, ""),
724724
),
725725
),
726726
VolumeMounts: []corev1.VolumeMount{
@@ -845,7 +845,7 @@ func (r *driverReconcile) reconcileControllerPluginDeployment() error {
845845
})
846846
}
847847
// OMap Generator Sidecar Container
848-
if r.isRdbDriver() && ptr.Deref(r.driver.Spec.GenerateOMapInfo, false) {
848+
if r.isRbdDriver() && ptr.Deref(r.driver.Spec.GenerateOMapInfo, false) {
849849
containers = append(containers, corev1.Container{
850850
Name: "csi-omap-generator",
851851
Image: r.images["plugin"],
@@ -1162,7 +1162,7 @@ func (r *driverReconcile) reconcileNodePluginDeamonSet() error {
11621162
kubeletDirPath := cmp.Or(pluginSpec.KubeletDirPath, defaultKubeletDirPath)
11631163
forceKernelClient := r.isCephFsDriver() && r.driver.Spec.CephFsClientType == csiv1.KernelCephFsClient
11641164

1165-
topology := r.isRdbDriver() && pluginSpec.Topology != nil
1165+
topology := r.isRbdDriver() && pluginSpec.Topology != nil
11661166
domainLabels := cmp.Or(pluginSpec.Topology, &csiv1.TopologySpec{}).DomainLabels
11671167
logRotationSpec := cmp.Or(r.driver.Spec.Log, &csiv1.LogSpec{}).Rotation
11681168
logRotationEnabled := logRotationSpec != nil
@@ -1189,7 +1189,7 @@ func (r *driverReconcile) reconcileNodePluginDeamonSet() error {
11891189
ServiceAccountName: serviceAccountName,
11901190
PriorityClassName: ptr.Deref(pluginSpec.PrioritylClassName, ""),
11911191
HostNetwork: true,
1192-
HostPID: r.isRdbDriver(),
1192+
HostPID: r.isRbdDriver(),
11931193
// to use e.g. Rook orchestrated cluster, and mons' FQDN is
11941194
// resolved through k8s service, set dns policy to cluster first
11951195
DNSPolicy: corev1.DNSClusterFirstWithHostNet,
@@ -1225,7 +1225,7 @@ func (r *driverReconcile) reconcileNodePluginDeamonSet() error {
12251225
"",
12261226
),
12271227
utils.If(
1228-
r.isRdbDriver(),
1228+
r.isRbdDriver(),
12291229
utils.StagingPathContainerArg(kubeletDirPath),
12301230
"",
12311231
),
@@ -1287,7 +1287,7 @@ func (r *driverReconcile) reconcileNodePluginDeamonSet() error {
12871287
if r.isCephFsDriver() {
12881288
mounts = append(mounts, utils.CsiMountInfoVolumeMount)
12891289
}
1290-
if r.isRdbDriver() {
1290+
if r.isRbdDriver() {
12911291
mounts = append(mounts, utils.OidcTokenVolumeMount)
12921292
}
12931293
if logRotationEnabled {
@@ -1427,7 +1427,7 @@ func (r *driverReconcile) reconcileNodePluginDeamonSet() error {
14271427
utils.KmsConfigVolume(&r.driver.Spec.Encryption.ConfigMapRef),
14281428
)
14291429
}
1430-
if r.isRdbDriver() {
1430+
if r.isRbdDriver() {
14311431
volumes = append(
14321432
volumes,
14331433
utils.OidcTokenVolume,
@@ -1496,7 +1496,7 @@ func (r *driverReconcile) reconcileLivenessService() error {
14961496
}
14971497
}
14981498

1499-
func (r *driverReconcile) isRdbDriver() bool {
1499+
func (r *driverReconcile) isRbdDriver() bool {
15001500
return r.driverType == RbdDriverType
15011501
}
15021502

0 commit comments

Comments
 (0)