Skip to content

Commit 4ec8321

Browse files
authored
Merge pull request #191 from Madhu-1/go1.23.0
ci: update go version to 1.23.0
2 parents 711b490 + 3b0bd6c commit 4ec8321

File tree

7 files changed

+21
-13
lines changed

7 files changed

+21
-13
lines changed

.github/workflows/lint.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ jobs:
5656
uses: golangci/golangci-lint-action@v6
5757
with:
5858
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
59-
version: v1.55
59+
version: v1.63
6060

6161
# Optional: golangci-lint command line arguments.
6262
args: --config=.golangci.yml

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Build the manager binary
2-
FROM golang:1.22 AS builder
2+
FROM golang:1.23 AS builder
33
ARG TARGETOS
44
ARG TARGETARCH
55

api/go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module github.com/ceph/ceph-csi-operator/api
22

3-
go 1.22.0
4-
5-
toolchain go1.22.5
3+
go 1.23.0
64

75
require (
86
k8s.io/api v0.30.3

go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module github.com/ceph/ceph-csi-operator
22

3-
go 1.22.0
4-
5-
toolchain go1.22.5
3+
go 1.23.0
64

75
require (
86
github.com/ceph/ceph-csi-operator/api v0.0.0-00010101000000-000000000000

test/e2e/e2e_suite_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ import (
2727
// Run e2e tests using the Ginkgo runner.
2828
func TestE2E(t *testing.T) {
2929
RegisterFailHandler(Fail)
30-
fmt.Fprintf(GinkgoWriter, "Starting ceph-csi-operator suite\n")
30+
_, err := fmt.Fprintf(GinkgoWriter, "Starting ceph-csi-operator suite\n")
31+
if err != nil {
32+
t.Fatalf("Failed to write to GinkgoWriter: %v", err)
33+
}
3134
RunSpecs(t, "e2e suite")
3235
}

test/utils/utils.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ const (
3535
)
3636

3737
func warnError(err error) {
38-
fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
38+
_, fErr := fmt.Fprintf(GinkgoWriter, "warning: %v\n", err)
39+
if fErr != nil {
40+
panic(fErr)
41+
}
3942
}
4043

4144
// InstallPrometheusOperator installs the prometheus Operator to be used to export the enabled metrics.
@@ -53,12 +56,18 @@ func Run(cmd *exec.Cmd) ([]byte, error) {
5356
cmd.Dir = dir
5457

5558
if err := os.Chdir(cmd.Dir); err != nil {
56-
fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
59+
_, fErr := fmt.Fprintf(GinkgoWriter, "chdir dir: %s\n", err)
60+
if fErr != nil {
61+
panic(fErr)
62+
}
5763
}
5864

5965
cmd.Env = append(os.Environ(), "GO111MODULE=on")
6066
command := strings.Join(cmd.Args, " ")
61-
fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
67+
_, err := fmt.Fprintf(GinkgoWriter, "running: %s\n", command)
68+
if err != nil {
69+
return nil, err
70+
}
6271
output, err := cmd.CombinedOutput()
6372
if err != nil {
6473
return output, fmt.Errorf("%s failed with error: (%v) %s", command, err, string(output))

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
## explicit; go 1.11
33
github.com/beorn7/perks/quantile
44
# github.com/ceph/ceph-csi-operator/api v0.0.0-00010101000000-000000000000 => ./api
5-
## explicit; go 1.22.0
5+
## explicit; go 1.23.0
66
github.com/ceph/ceph-csi-operator/api/v1alpha1
77
# github.com/cespare/xxhash/v2 v2.3.0
88
## explicit; go 1.11

0 commit comments

Comments
 (0)