Conversation
Collaborator
Author
|
@Madhu-1, PTAL. |
Madhu-1
reviewed
Jan 14, 2025
obnoxxx
force-pushed
the
rework-golangci-lint
branch
from
c183698 to
3eeb4cc
Compare
obnoxxx
force-pushed
the
rework-golangci-lint
branch
from
3eeb4cc to
b682f5b
Compare
This makes the golangci-lint related targets a bit more systematic and consistent. Signed-off-by: Michael Adam <obnox@samba.org>
this makes sure thwe same version is used locally and in the CI. Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
rework-golangci-lint
branch
from
ecaf7fa to
1f9a737
Compare
Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
rework-golangci-lint
branch
from
1f9a737 to
cf9a9f5
Compare
Madhu-1
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This PR reworks the golangci-lint make targets a bit to make them more consistent and systematic.
While at it, it makes sure the same version of golangci-lint is used locally and in the CI.
Finally, the
lintCI workflow is changed to use the golangci-lint make target instead of the corresponding github action.Is there anything that requires special attention
Is the change backward compatible?
yes.
Are there concerns around backward compatibility?
no.
Future concerns
none
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.