Operator fails to set --setmetadata=false

[sshambar]

Describe the bug

The Driver.spec.enableMetadata is false by default, but the reconciler only applies --setmetadata=true if enableMetadata is true -- however --setmetadata is true by default, so the key has no effect.

Environment details

• Image/version of ceph-csi-operator : 0.4.1
• Image/version of Ceph-CSI driver : v3.15.0
• Kubernetes cluster version : v1.33.5
• Ceph cluster version : 19.2.3

Steps to reproduce

Steps to reproduce the behavior:

1. Set a Driver.spec.enableMetadata: false (or don't specify it)
2. Apply the driver, and examine the ctrlplugin controller deployment

Actual results

The csi-cephfsplugin container args doesn't include '--setmetadata={bool}'

Expected behavior

The csi-cephfsplugin container args should include '--setmetadata=false'

Additional context

For ref: kubectl exec <ctrlplugin-pod> -- /usr/local/bin/cephcsi -h provides:

  -setmetadata
        set metadata on the volume (default true)

[Madhu-1]

@sshambar Do you have any usecase where you want it to be set? we have plan to deprecate this in cephcsi because the supported ceph version have the required support for metadata

[sshambar]

I don't personally use the setting, but I just noticed the inconsistency in the defaults between the chart and driver. If I submit a PR, should I just update the default to true and fix the application of the parameter if false? (or just remove the option entirely?)

[Madhu-1]

we dont need any changes in the csi operator, we are planning to deprecate the option in csi and also the option in the csi-operator will also gets deprecate, once the changes are mergedin csi, we can use this tracker to deprecate the csi-operator configuration as well