Allow underscore in volume ID#6094
Merged
mergify[bot] merged 1 commit intoceph:develfrom Feb 20, 2026
Merged
Conversation
Member
|
@black-dragon74 , please have a look. If this is correct, we can add the |
Member
|
Looks good to me. Thanks @FreekingDean, you can use For the commitlint, the commit msg could look something like: |
FreekingDean
force-pushed
the
fix/allow-underscore
branch
from
2bb3bd8 to
e81ca5a
Compare
Signed-off-by: Dean Galvin <deangalvin3@gmail.com>
FreekingDean
force-pushed
the
fix/allow-underscore
branch
from
e81ca5a to
697b0d4
Compare
Madhu-1
approved these changes
Feb 20, 2026
nixpanic
approved these changes
Feb 20, 2026
Member
|
@Mergifyio queue |
Contributor
Merge Queue StatusRule:
This pull request spent 2 hours 59 minutes in the queue, including 2 hours 58 minutes 46 seconds running CI. Required conditions to merge
|
78 tasks
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-cephfs |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
Collaborator
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.33 |
Collaborator
|
/test ci/centos/upgrade-tests-rbd |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.33 |
Collaborator
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.34 |
Collaborator
|
/test ci/centos/mini-e2e/k8s-1.35 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This updates the regex that handles volume ID validation to allow underscores in the volume ID. I have a volume with an underscore in the name, which when the volume ID is parsed in grpc requests & validate it returns an error since v3.16.1 I have updated the regex to include an
_character in the last portion, as well as added a test validating the new behavior.Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Yes
Are there concerns around backward compatibility?
No
Provide any external context for the change, if any.
For example:
Since v3.16.1 I get this error:
This is a result of the fact that ceph_ec (my volume) has an underscore which is reading as invalid.
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #issue_number
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)