Skip to content

Commit 5009896

Browse files
committed
build: remove boost_system linkage for boost 1.89+
In boost 1.89, the stub compiled library for Boost.System was removed. According to the boost 1.89 release notes: "The stub compiled library has been removed; System has been header-only since release 1.69." See https://www.boost.org/releases/1.89.0/ . This change removes boost_system from target_link_libraries() calls where other boost libraries are already linked. When linking against other boost components (such as boost_thread, boost_date_time, or boost_filesystem), the header-only System library dependency is automatically satisfied, making explicit linkage against the (now non-existent) compiled boost_system library unnecessary. This is not a breaking change since the minimum required boost version for this project is 1.87, where Boost.System was already header-only. Signed-off-by: Kefu Chai <k.chai@proxmox.com>
1 parent 58fe02f commit 5009896

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

example/CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ if(Arrow_FOUND)
77
message( "arrow is installed")
88
add_executable(csv_to_parquet csv_to_parquet.cpp)
99
target_include_directories(csv_to_parquet PUBLIC ../include)
10-
target_link_libraries(s3select_example boost_date_time boost_system boost_thread parquet arrow boost_filesystem)
11-
target_link_libraries(csv_to_parquet boost_date_time boost_system boost_thread parquet arrow)
10+
target_link_libraries(s3select_example boost_date_time boost_thread parquet arrow boost_filesystem)
11+
target_link_libraries(csv_to_parquet boost_date_time boost_thread parquet arrow)
1212
else()
13-
target_link_libraries(s3select_example boost_date_time boost_system boost_thread boost_filesystem)
13+
target_link_libraries(s3select_example boost_date_time boost_thread boost_filesystem)
1414
endif()
1515

1616
add_executable(generate_rand_csv generate_rand_csv.c)

test/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ find_package(Arrow QUIET)
1111

1212
if(Arrow_FOUND)
1313
message( "arrow is installed")
14-
target_link_libraries(s3select_test gtest gtest_main boost_date_time boost_thread boost_system parquet arrow pthread )
15-
target_link_libraries(s3select_perf_test gtest gtest_main boost_date_time boost_thread boost_system parquet arrow pthread profiler)
16-
target_link_libraries(s3select_test_json_parser gtest gtest_main boost_date_time boost_thread boost_system parquet arrow pthread )
14+
target_link_libraries(s3select_test gtest gtest_main boost_date_time boost_thread parquet arrow pthread )
15+
target_link_libraries(s3select_perf_test gtest gtest_main boost_date_time boost_thread parquet arrow pthread profiler)
16+
target_link_libraries(s3select_test_json_parser gtest gtest_main boost_date_time boost_thread parquet arrow pthread )
1717
else()
18-
target_link_libraries(s3select_test gtest gtest_main boost_date_time boost_thread boost_system pthread )
19-
target_link_libraries(s3select_perf_test gtest gtest_main boost_date_time boost_thread boost_system pthread profiler)
20-
target_link_libraries(s3select_test_json_parser gtest gtest_main boost_date_time boost_thread boost_system pthread )
18+
target_link_libraries(s3select_test gtest gtest_main boost_date_time boost_thread pthread )
19+
target_link_libraries(s3select_perf_test gtest gtest_main boost_date_time boost_thread pthread profiler)
20+
target_link_libraries(s3select_test_json_parser gtest gtest_main boost_date_time boost_thread pthread )
2121
endif()
2222

2323
include(GoogleTest)

0 commit comments

Comments
 (0)