Skip to content

Commit 237c789

Browse files
author
Kyr Shatskyy
committed
setup.cfg: fix teuthology-openstack dependency
The PR #2050 "Revive teuthology-openstack" introduced new dependency after refactoring partly of teuthology.openstack instance classes to use api instead of command line. However the openstacksdk added to wrong section options.extras_require.openstack, that intended to be used for provisioning openstack nodes via libcloud, which is optional and is not installable by default. I.e. `pip install -e ".[openstack]"` must be used in order to get it. However the refactoring forced unconditional openstack requirement. That's why this dependency should go to options.install_requires in order to make `pip install -e .` work again. Fixes: 252ab4f Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
1 parent d44278d commit 237c789

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

setup.cfg

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ install_requires =
4444
lxml
4545
ndg-httpsclient
4646
netaddr
47+
openstacksdk # teuthology-openstack dependencies
4748
paramiko
4849
pexpect
4950
pip-tools
@@ -107,10 +108,10 @@ test =
107108
toml
108109
tox
109110
xmltodict
111+
# libcloud openstack dependencies
110112
openstack =
111113
python-openstackclient
112114
python-novaclient
113-
openstacksdk
114115

115116
[options.package_data]
116117
teuthology.openstack =

0 commit comments

Comments
 (0)