Skip to content

Commit e6ac85f

Browse files
author
Abdul Rabbani
committed
Remove redundant deferences for pointers
1 parent 3477d35 commit e6ac85f

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

‎statediff/builder_test.go‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ func TestBuilder(t *testing.T) {
702702
if err != nil {
703703
t.Error(err)
704704
}
705-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
705+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
706706
if err != nil {
707707
t.Error(err)
708708
}
@@ -965,7 +965,7 @@ func TestBuilderWithIntermediateNodes(t *testing.T) {
965965
if err != nil {
966966
t.Error(err)
967967
}
968-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
968+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
969969
if err != nil {
970970
t.Error(err)
971971
}
@@ -1155,7 +1155,7 @@ func TestBuilderWithWatchedAddressList(t *testing.T) {
11551155
if err != nil {
11561156
t.Error(err)
11571157
}
1158-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
1158+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
11591159
if err != nil {
11601160
t.Error(err)
11611161
}
@@ -1385,7 +1385,7 @@ func TestBuilderWithRemovedAccountAndStorage(t *testing.T) {
13851385
if err != nil {
13861386
t.Error(err)
13871387
}
1388-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
1388+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
13891389
if err != nil {
13901390
t.Error(err)
13911391
}
@@ -1583,7 +1583,7 @@ func TestBuilderWithRemovedAccountAndStorageWithoutIntermediateNodes(t *testing.
15831583
t.Error(err)
15841584
}
15851585

1586-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
1586+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
15871587
if err != nil {
15881588
t.Error(err)
15891589
}
@@ -1701,7 +1701,7 @@ func TestBuilderWithRemovedNonWatchedAccount(t *testing.T) {
17011701
t.Error(err)
17021702
}
17031703

1704-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
1704+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
17051705
if err != nil {
17061706
t.Error(err)
17071707
}
@@ -1871,7 +1871,7 @@ func TestBuilderWithRemovedWatchedAccount(t *testing.T) {
18711871
t.Error(err)
18721872
}
18731873

1874-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
1874+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
18751875
if err != nil {
18761876
t.Error(err)
18771877
}
@@ -2103,7 +2103,7 @@ func TestBuilderWithMovedAccount(t *testing.T) {
21032103
if err != nil {
21042104
t.Error(err)
21052105
}
2106-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
2106+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
21072107
if err != nil {
21082108
t.Error(err)
21092109
}
@@ -2239,7 +2239,7 @@ func TestBuilderWithMovedAccountOnlyLeafs(t *testing.T) {
22392239
if err != nil {
22402240
t.Error(err)
22412241
}
2242-
expectedStateDiffRlp, err := rlp.EncodeToBytes(&test.expected)
2242+
expectedStateDiffRlp, err := rlp.EncodeToBytes(test.expected)
22432243
if err != nil {
22442244
t.Error(err)
22452245
}
@@ -2470,7 +2470,7 @@ func TestBuildStateTrie(t *testing.T) {
24702470
if err != nil {
24712471
t.Error(err)
24722472
}
2473-
expectedStateTrieRlp, err := rlp.EncodeToBytes(&test.expected)
2473+
expectedStateTrieRlp, err := rlp.EncodeToBytes(test.expected)
24742474
if err != nil {
24752475
t.Error(err)
24762476
}

‎statediff/indexer/ipld/eth_header.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ var _ node.Node = (*EthHeader)(nil)
4646

4747
// NewEthHeader converts a *types.Header into an EthHeader IPLD node
4848
func NewEthHeader(header *types.Header) (*EthHeader, error) {
49-
headerRLP, err := rlp.EncodeToBytes(&header)
49+
headerRLP, err := rlp.EncodeToBytes(header)
5050
if err != nil {
5151
return nil, err
5252
}

‎statediff/mainnet_tests/builder_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ func init() {
420420
}
421421
db = rawdb.NewMemoryDatabase()
422422
genesisBlock = core.DefaultGenesisBlock().MustCommit(db)
423-
genBy, err := rlp.EncodeToBytes(&genesisBlock)
423+
genBy, err := rlp.EncodeToBytes(genesisBlock)
424424
if err != nil {
425425
log.Fatal(err)
426426
}
@@ -671,7 +671,7 @@ func TestBuilderOnMainnetBlocks(t *testing.T) {
671671
if err != nil {
672672
t.Error(err)
673673
}
674-
receivedStateDiffRlp, err := rlp.EncodeToBytes(&diff)
674+
receivedStateDiffRlp, err := rlp.EncodeToBytes(diff)
675675
if err != nil {
676676
t.Error(err)
677677
}

‎statediff/service_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func testErrorInStateDiffAt(t *testing.T) {
235235
if err != nil {
236236
t.Error(err)
237237
}
238-
expectedBlockRlp, err := rlp.EncodeToBytes(&testBlock1)
238+
expectedBlockRlp, err := rlp.EncodeToBytes(testBlock1)
239239
if err != nil {
240240
t.Error(err)
241241
}
@@ -269,7 +269,7 @@ func testErrorInStateDiffAt(t *testing.T) {
269269
if err != nil {
270270
t.Error(err)
271271
}
272-
stateDiffPayloadRlp, err := rlp.EncodeToBytes(&stateDiffPayload)
272+
stateDiffPayloadRlp, err := rlp.EncodeToBytes(stateDiffPayload)
273273
if err != nil {
274274
t.Error(err)
275275
}

‎statediff/test_helpers/mocks/service_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func testSubscriptionAPI(t *testing.T) {
9797
defer chain.Stop()
9898
block0 = test_helpers.Genesis
9999
block1 = blocks[0]
100-
expectedBlockRlp, _ := rlp.EncodeToBytes(&block1)
100+
expectedBlockRlp, _ := rlp.EncodeToBytes(block1)
101101
mockReceipt := &types.Receipt{
102102
BlockNumber: block1.Number(),
103103
BlockHash: block1.Hash(),
@@ -189,7 +189,7 @@ func testHTTPAPI(t *testing.T) {
189189
defer chain.Stop()
190190
block0 = test_helpers.Genesis
191191
block1 = blocks[0]
192-
expectedBlockRlp, _ := rlp.EncodeToBytes(&block1)
192+
expectedBlockRlp, _ := rlp.EncodeToBytes(block1)
193193
mockReceipt := &types.Receipt{
194194
BlockNumber: block1.Number(),
195195
BlockHash: block1.Hash(),

0 commit comments

Comments
 (0)