Skip to content

fix: more reliable check of module is included #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: more reliable check of module is included #1418

merged 1 commit into from
Oct 27, 2023

Conversation

bf4
Copy link
Collaborator

@bf4 bf4 commented Oct 22, 2023 •
edited
Loading

target is #1411

handle gems like GraphQL which override include?

rake aborted!
ArgumentError: wrong number of arguments (given 1, expected 3)
gems/graphql-2.0.13/lib/graphql/schema/directive.rb:58:in `include?'

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@bf4
fix: more reliable check of module is included
72af8fd 
handle gems like GraphQL which override `include?`

```
rake aborted!
ArgumentError: wrong number of arguments (given 1, expected 3)
gems/graphql-2.0.13/lib/graphql/schema/directive.rb:58:in `include?'
```
@bf4
Copy link
Collaborator Author

bf4 commented Oct 24, 2023

@lgebhardt I'm not sure what's causing these test failure in this branch but not in the target branch. Any objection to merging this and resolving anything there which may or may not show up?

@bf4 bf4 requested a review from lgebhardt October 24, 2023 15:13
@bf4 bf4 merged commit 81e4ecf into v0-11-dev Oct 27, 2023
@bf4 bf4 deleted the better_check branch October 27, 2023 17:58
lgebhardt pushed a commit that referenced this pull request Apr 18, 2024
@bf4 @lgebhardt
fix: more reliable check of module is included (#1418)
fdbf26e 
handle gems like GraphQL which override `include?`

```
rake aborted!
ArgumentError: wrong number of arguments (given 1, expected 3)
gems/graphql-2.0.13/lib/graphql/schema/directive.rb:58:in `include?'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgebhardt lgebhardt Awaiting requested review from lgebhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bf4