Skip to content

Commit 62efa98

Browse files
committed
Return 201 when the hint is enqueued
1 parent f6fe3ab commit 62efa98

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

jens/webapps/gitlabproducer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def hello_gitlab():
5555
partition, name = _partition, _name
5656

5757
enqueue_hint(partition, name)
58-
return 'OK'
58+
return 'OK', 201
5959
except JensMessagingError as error:
6060
logging.error("%s/%s couldn't be added to the queue (%s)" %
6161
(partition, name, str(error)))

jens/webapps/test/test_gitlabproducer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def test_known_repository(self, mock_eq):
6060
}
6161
}))
6262
mock_eq.assert_called_once_with('common', 'site')
63-
self.assertEqual(reply.status_code, 200)
63+
self.assertEqual(reply.status_code, 201)
6464

6565
@patch('jens.webapps.gitlabproducer.enqueue_hint', side_effect=JensMessagingError)
6666
def test_queue_error(self, mock_eq):
@@ -99,7 +99,7 @@ def test_secret_token_ignored_if_not_configured(self, mock_eq):
9999
headers={'X-Gitlab-Token': 'tokenvalue'},
100100
data=json.dumps(_payload))
101101
mock_eq.assert_called_once_with('common', 'site')
102-
self.assertEqual(reply.status_code, 200)
102+
self.assertEqual(reply.status_code, 201)
103103

104104
def test_wrong_secret_token(self):
105105
self.settings.GITLAB_PRODUCER_SECRET_TOKEN = 'expected'
@@ -142,4 +142,4 @@ def test_secret_token_configured_good_token(self, mock_eq):
142142
headers={'X-Gitlab-Token': 'expected'},
143143
data=json.dumps(_payload))
144144
mock_eq.assert_called_once_with('common', 'site')
145-
self.assertEqual(reply.status_code, 200)
145+
self.assertEqual(reply.status_code, 201)

0 commit comments

Comments
 (0)