Skip to content

Commit 60a2d87

Browse files
committed
acquire requestToPrivateKey lock at the start of the event handler
Signed-off-by: James Munnelly <[email protected]>
1 parent 1885342 commit 60a2d87

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

manager/manager.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,8 @@ func NewManager(opts Options) (*Manager, error) {
171171
lister := informerFactory.Certmanager().V1().CertificateRequests().Lister()
172172
informerFactory.Certmanager().V1().CertificateRequests().Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
173173
DeleteFunc: func(obj interface{}) {
174+
requestToPrivateKeyLock.Lock()
175+
defer requestToPrivateKeyLock.Unlock()
174176
key, ok := obj.(string)
175177
if !ok {
176178
return
@@ -186,8 +188,6 @@ func NewManager(opts Options) (*Manager, error) {
186188
return
187189
}
188190

189-
requestToPrivateKeyLock.Lock()
190-
defer requestToPrivateKeyLock.Unlock()
191191
if _, ok := requestToPrivateKeyMap[req.UID]; ok {
192192
delete(requestToPrivateKeyMap, req.UID)
193193
}

0 commit comments

Comments
 (0)