Skip to content

Commit 64f764b

Browse files
Merge pull request #1571 from wallrj/new-feature-flags
Add a theme about logging improvements
2 parents 8c722ec + 841ef3c commit 64f764b

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

content/docs/installation/configuring-components.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ featureGates:
5555
UseCertificateRequestBasicConstraints: true
5656
OtherNames: true
5757
NameConstraints: true
58+
UseDomainQualifiedFinalizer: true
5859
```
5960
6061
> **Note:** This is included as an example only and not intended to be used as default settings.

content/docs/releases/release-notes/release-notes-1.16.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,24 @@ And it reduces the peak memory use of the cert-manager components when they star
139139
because they no longer have to hold a duplicate unpaged list of resources in-memory
140140
while they add them to the client side cache.
141141
142+
### Logging
143+
144+
We have improved the signal-to-noise ratio in the logs.
145+
146+
The controller has a new feature gate: `UseDomainQualifiedFinalizer`.
147+
This changes the finalizer added to ACME Challenge resources,
148+
from `finalizer.acme.cert-manager.io` to `acme.cert-manager.io/finalizer`.
149+
The new finalizer name is [compliant with Kubernetes standards](https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#finalizers),
150+
and will resolve warnings in cert-manager-controller pods of the form:
151+
> `W0910 20:07:22.491920 1 warnings.go:70] metadata.finalizers: "finalizer.acme.cert-manager.io": prefer a domain-qualified finalizer name to avoid accidental conflicts with other finalizer writers`
152+
153+
Read [cert-manager component configuration: Feature gates](../../installation/configuring-components.md#feature-gates) to learn more.
154+
155+
cert-manager now uses client-go `v0.31.0`, which removes a lot of noisy errors from logs, of the form:
156+
> `reflector.go: unable to sync list result: internal error: cannot cast object DeletedFinalStateUnknown`
157+
158+
Read [cert-manager issue 6753](https://github.com/cert-manager/cert-manager/issues/6753) to learn more.
159+
142160
## Community
143161
144162
Thanks again to all open-source contributors with commits in this release, including: TODO

0 commit comments

Comments
 (0)