BUG: lib/utils: fix check on bot docstring

Sebastian Wagner · waldbauer-certat · commit 14d1b0c40460 · 2021-03-15T10:18:07.000+01:00
make it more robust if the docstring does not exist
diff --git a/intelmq/lib/utils.py b/intelmq/lib/utils.py
@@ -849,7 +849,7 @@ def list_all_bots() -> dict:
 
             bots[file.parts[2].capitalize()[:-1]][name] = {
                 "module": mod.__name__,
-                "description": "Missing description" if not hasattr(mod.BOT, '__doc__') else textwrap.dedent(mod.BOT.__doc__),
+                "description": "Missing description" if not getattr(mod.BOT, '__doc__', None) else textwrap.dedent(mod.BOT.__doc__),
                 "parameters": keys,
             }
     return bots

Original file line number	Diff line number	Diff line change
`@@ -849,7 +849,7 @@ def list_all_bots() -> dict:`
`849`	`849`
`850`	`850`	`bots[file.parts[2].capitalize()[:-1]][name] = {`
`851`	`851`	`"module": mod.__name__,`
`852`		`- "description": "Missing description" if not hasattr(mod.BOT, '__doc__') else textwrap.dedent(mod.BOT.__doc__),`
	`852`	`+ "description": "Missing description" if not getattr(mod.BOT, '__doc__', None) else textwrap.dedent(mod.BOT.__doc__),`
`853`	`853`	`"parameters": keys,`
`854`	`854`	`}`
`855`	`855`	`return bots`