File tree Expand file tree Collapse file tree 3 files changed +8
-1
lines changed
tests/bots/parsers/generic Expand file tree Collapse file tree 3 files changed +8
-1
lines changed Original file line number Diff line number Diff line change @@ -25,6 +25,7 @@ Please refer to the [NEWS](NEWS.md) for a list of changes which have an affect o
2525#### Collectors
2626
2727#### Parsers
28+ - ` intelmq.bots.parsers.generic_csv.parser_csv ` : Handle empty string parameter ` columns_required ` as unset (PR #2680 by Sebastian Wagner, fixes #2679 ).
2829
2930#### Experts
3031
Original file line number Diff line number Diff line change @@ -68,7 +68,7 @@ def init(self):
6868 expected = ("blacklist" , "whitelist" ),
6969 docs = DOCS )
7070
71- if self .columns_required is None :
71+ if self .columns_required in [ None , '' ] :
7272 self .columns_required = [True for _ in self .columns ]
7373 if len (self .columns ) != len (self .columns_required ):
7474 raise ValueError ("Length of parameters 'columns' (%d) and 'columns_required' (%d) "
Original file line number Diff line number Diff line change @@ -105,6 +105,12 @@ def test_compose_fields(self):
105105 'delimiter' : ',' })
106106 self .assertMessageEqual (0 , COMPOSE_EVENT )
107107
108+ def test_empty_required_colums (self ):
109+ """ #2679 """
110+ self .run_bot (parameters = {'columns_required' : '' })
111+ self .assertMessageEqual (0 , EXAMPLE_EVENT )
112+ self .run_bot (parameters = {'columns_required' : None })
113+
108114
109115if __name__ == '__main__' : # pragma: no cover
110116 unittest .main ()
You can’t perform that action at this time.
0 commit comments