Skip to content

Commit 6278f15

Browse files
author
Sebastian Wagner
committed
DOC: minor additions to the xmpp bots deprecation texts
1 parent f5416e4 commit 6278f15

File tree

4 files changed

+18
-11
lines changed

4 files changed

+18
-11
lines changed

CHANGELOG.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ CHANGELOG
1111
- `ParserBot.recover_line_json_stream`: Make `line` parameter optional, as it is not needed for this method.
1212
- `Bot.argparser`: Added class method `_create_argparser` (returns `argparse.ArgumentParser`) for easy command line arguments parsing.
1313
- Runtime configuration does not necessarily need a parameter entry for each block. Previously and at least empty block was required (PR#1604 by Filip Pokorný).
14-
- Allow setting the pipeline host and the redis cache host by environment variables for docker usage (PR#1669 by Sebastian Waldbauer).
14+
- Allow setting the pipeline host and the Redis cache host by environment variables for docker usage (PR#1669 by Sebastian Waldbauer).
1515
- `intelmq.lib.upgrades`:
1616
- Add upgrade function for removal of *HPHosts Hosts file* feed and `intelmq.bots.parsers.hphosts` parser (#1559).
1717
- `intelmq.lib.exceptions`:
@@ -20,7 +20,7 @@ CHANGELOG
2020
- `create_request_session_from_bot`: Changed bot argument to optional, uses defaults.conf as fallback, renamed to `create_request_session`. Name `create_request_session_from_bot` will be removed in version 3.0.0.
2121
- `log`: Use RotatingFileHandler for allow log file rotation without external tools (PR#1637 by Vasek Bruzek).
2222
- `intelmq.lib.harmonization`:
23-
- The `IPAddress` type sanitiation now accepts integer IP addresses and converts them to the string representation.
23+
- The `IPAddress` type sanitation now accepts integer IP addresses and converts them to the string representation.
2424

2525
### Development
2626
- `intelmq.bin.intelmq_gen_docs`: Add bot name to the `Feeds.md` documentation (PR#1617 by Birger Schacht).
@@ -33,8 +33,8 @@ CHANGELOG
3333
- `intelmq.bots.collectors.http.collector_http`:
3434
- Added PGP signature check functionality (PR#1602 by sinus-x).
3535
- If status code is not 2xx, the request's and response's headers and body are logged in debug logging level (#1615).
36-
- `intelmq.bots.collectors.kafka.collector`: Added (PR#1654, closes #1634)
37-
- `intelmq.bots.collectors.xmpp.collector`: marked as deprecated (see https://lists.cert.at/pipermail/intelmq-users/2020-October/000177.html)
36+
- `intelmq.bots.collectors.kafka.collector`: Added (PR#1654 by Birger Schacht, closes #1634)
37+
- `intelmq.bots.collectors.xmpp.collector`: Marked as deprecated, see https://lists.cert.at/pipermail/intelmq-users/2020-October/000177.html (#1614, PR#1685 by Birger Schacht).
3838

3939
#### Parsers
4040
- `intelmq.bots.parsers.eset.parser`: Added (PR#1554 by Mikk Margus Möll).
@@ -74,7 +74,7 @@ CHANGELOG
7474

7575
#### Outputs
7676
- `intelmq.bots.outputs.rt`: Added Request Tracker output bot (PR#1589 by Marius Urkis).
77-
- `intelmq.bots.outputs.xmpp.output`: marked as deprecated (see https://lists.cert.at/pipermail/intelmq-users/2020-October/000177.html)
77+
- `intelmq.bots.outputs.xmpp.output`: Marked as deprecated, see https://lists.cert.at/pipermail/intelmq-users/2020-October/000177.html (#1614, PR#1685 by Birger Schacht).
7878

7979
### Documentation
8080
- Feeds:
@@ -87,7 +87,7 @@ CHANGELOG
8787
- Bots:
8888
- Enhanced documentation of RFC1918 Expert.
8989
- Enhanced documentation of SQL Output (PR #1620 by Edvard Rejthar).
90-
- Updated documentation for Maxmind GeoIP, ASN Lookup, TOR Nodes and Recorded Future experts to reflect new `--update-database` option. (PR#1524 by Filip Pokorný)
90+
- Updated documentation for MaxMind GeoIP, ASN Lookup, TOR Nodes and Recorded Future experts to reflect new `--update-database` option. (PR#1524 by Filip Pokorný)
9191
- Add n6 Integration documentation.
9292
- Moved 'Orphaned Queues' section from the FAQ to the intelmqctl documentation.
9393
- Generate documentation using Sphinx (PR#1622 by Birger Schacht).
@@ -117,7 +117,7 @@ CHANGELOG
117117
- Allow setting the pipeline host by environment variables for docker usage (PR#1669 by Sebastian Waldbauer).
118118

119119
### Contrib
120-
- eventdb:
120+
- EventDB:
121121
- Add SQL script for keeping track of the oldest inserted/update "time.source" information.
122122
- Cron Jobs: The script `intelmq-update-data` has been renamed to `intelmq-update-database`
123123

NEWS.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ The documentation is now available at [intelmq.readthedocs.io](https://intelmq.r
3232
The provided shell scripts use these new commands, however they are now deprecated and will be removed in version 3.0.
3333

3434
#### XMPP Bots
35-
Both the XMPP output bot and the XMPP collector bot log a deprecation warning now. The plan is to remove them in version 3.0.
35+
Both the XMPP output bot and the XMPP collector bot are deprecated.
36+
The bots need to be migrate to another XMPP library (see [#1614](https://github.com/certtools/intelmq/issues/1614) for details) and a survey on the mailing listed revealed no users.
37+
If you depend on this bot, please reach out to us via the mailing list or GitHub.
38+
The bots are logging a deprecation warning now and the current plan is to remove them in IntelMQ version 3.0.
3639

3740
### Harmonization
3841

intelmq/bots/collectors/xmpp/collector.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,10 @@ class XMPPCollectorBot(CollectorBot):
8383
collector_empty_process = True
8484

8585
def init(self):
86-
self.logger.warning("The output bot 'intelmq.bots.outputs.xmpp.output' "
87-
"is deprecated. It will be removed in version 3.0.")
86+
self.logger.warning("The output bot 'intelmq.bots.collectors.xmpp.output' "
87+
"is deprecated. It will be removed in version 3.0."
88+
"Please see https://github.com/certtools/intelmq/blob/"
89+
"develop/NEWS.md#xmpp-bots for more details.")
8890
if sleekxmpp is None:
8991
raise MissingDependencyError("sleekxmpp")
9092

intelmq/bots/outputs/xmpp/output.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,9 @@ class XMPPOutputBot(Bot):
8282

8383
def init(self):
8484
self.logger.warning("The output bot 'intelmq.bots.outputs.xmpp.output' "
85-
"is deprecated. It will be removed in version 3.0.")
85+
"is deprecated. It will be removed in version 3.0."
86+
"Please see https://github.com/certtools/intelmq/blob/"
87+
"develop/NEWS.md#xmpp-bots for more details.")
8688
if sleekxmpp is None:
8789
raise MissingDependencyError("sleekxmpp")
8890

0 commit comments

Comments
 (0)