BUG: lib/utils: list_all_bots: exclude Bot paramers

exclude parameters of the parent Bot class if the values are not
different (i.e. global defaults).

Author: Sebastian Wagner

intelmq/lib/utils.py

@@ -822,13 +822,26 @@ def file_name_from_response(response: requests.Response) -> str:
 
 
 def list_all_bots() -> dict:
+    """
+    Compile a dictionary with all bots and their parameters.
+
+    Includes
+    * the bots' names
+    * the description from the docstring
+    * parameters including default values.
+
+    For the parameters, parameters of the Bot class are excluded if they have the same value.
+    """
     bots = {
         'Collector': {},
         'Parser': {},
         'Expert': {},
         'Output': {},
     }
 
+    from intelmq.lib.bot import Bot  # noqa: prevents circular import
+    bot_parameters = dir(Bot)
+
     base_path = resource_filename('intelmq', 'bots')
 
     botfiles = [botfile for botfile in pathlib.Path(base_path).glob('**/*.py') if botfile.is_file() and botfile.name != '__init__.py']
@@ -841,7 +854,9 @@ def list_all_bots() -> dict:
             variables = sorted((key) for key in dir(mod.BOT) if not key.isupper() and not key.startswith('_'))
             for variable in variables:
                 value = getattr(mod.BOT, variable)
-                if not inspect.ismethod(value) and not inspect.isfunction(value) and not inspect.isclass(value) and not inspect.isroutine(value):
+                if (not inspect.ismethod(value) and not inspect.isfunction(value) and
+                        not inspect.isclass(value) and not inspect.isroutine(value) and
+                        not (variable in bot_parameters and getattr(Bot, variable) == value)):
                     keys[variable] = value
 
             for bot_type in ['CollectorBot', 'ParserBot', 'OutputBot', 'Bot']: