BUG: generic csv: fix time_format empty string handling

Author: Sebastian Wagner

CHANGELOG.md

@@ -82,6 +82,8 @@ Update allowed classification fields to 2020-01-28 version (#1409, #1476).
 - Added `intelmq.bots.parsers.fireeye`: A bot that parses hashes and URLs from Fireeye MAS indicators (PR#1745 by Christopher Schappelwein).
 - `intelmq.bots.parsers.shadowserver._config`:
   - Improved the feed-mapping and all conversion functions (PR#1971 by Mikk Margus Möll).
+- `intelmq.bots.parsers.generic.parser_csv`:
+  - Fix handling of empty string values for parameter `time_format` (by Sebastian Wagner).
 
 #### Experts
 - `intelmq.bots.experts.domain_suffix.expert`: Added `--update-database` option to update domain suffix database.

intelmq/bots/parsers/generic/parser_csv.py

@@ -68,6 +68,9 @@ def init(self):
         # prevents empty strings:
         self.column_regex_search = self.column_regex_search or {}
 
+        # handle empty strings, false etc.
+        if not self.time_format:
+            self.time_format = None
         if self.time_format not in TIME_CONVERSIONS.keys():
             raise InvalidArgument('time_format', got=self.time_format,
                                   expected=list(TIME_CONVERSIONS.keys()),

intelmq/tests/bots/parsers/generic/test_parser_csv.py

@@ -80,6 +80,11 @@ def test_event(self):
         self.assertMessageEqual(0, EXAMPLE_EVENT)
         self.assertMessageEqual(1, EXAMPLE_EVENT2)
 
+    def test_time_format_empty_string(self):
+        """ Test if empty string value for parameter time_format is handled correctly. """
+        self.run_bot(parameters={'time_format': ''})
+        self.assertMessageEqual(0, EXAMPLE_EVENT)
+
     def test_strcol(self):
         self.run_bot(parameters={"columns": "time.source, __IGNORE__,"
                                             "event_description.text, __IGNORE__,"