Skip to content

Commit e606efc

Browse files
authored
Merge pull request #2208 from certtools/fix-2206
tst: fix reverse_dns test
2 parents 79cae29 + 7969687 commit e606efc

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ CHANGELOG
103103
- Also test on Python 3.10 (PR#2140 by Sebastian Wagner).
104104
- Switch from nosetests to pytest, as the former does not support Python 3.10 (PR#2140 by Sebastian Wagner).
105105
- CodeQL Github Actions `exponential backtracking on strings` fixed. (PR#2148 by Sebastian Waldbauer, fixes #2138)
106+
- Reverse DNS expert tests: remove outdated failing test `test_invalid_ptr` (PR#2208 by Sebastian Wagner, fixes #2206).
106107

107108
### Tools
108109
- `intelmqctl`: fix process manager initialization if run non-interactively, as intelmqdump does it (PR#2189 by Sebastian Wagner, fixes 2188).

intelmq/tests/bots/experts/reverse_dns/test_expert.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,6 @@
3333
"source.reverse_dns": "iana.org",
3434
"time.observation": "2015-01-01T00:00:00+00:00",
3535
}
36-
INVALID_PTR_INP = {"__type": "Event",
37-
"source.ip": "31.210.115.39", # PTR is '.'
38-
"time.observation": "2015-01-01T00:00:00+00:00",
39-
}
40-
INVALID_PTR_OUT = {"__type": "Event",
41-
"source.ip": "31.210.115.39",
42-
"time.observation": "2015-01-01T00:00:00+00:00",
43-
}
4436
INVALID_PTR_INP2 = {"__type": "Event",
4537
"source.ip": "5.157.80.221", # PTR is '5.157.80.221.' and 'aliancys.peopleinc.nl.'
4638
"time.observation": "2015-01-01T00:00:00+00:00",
@@ -82,11 +74,6 @@ def test_ipv6_lookup(self):
8274
self.run_bot()
8375
self.assertMessageEqual(0, EXAMPLE_OUTPUT6)
8476

85-
def test_invalid_ptr(self):
86-
self.input_message = INVALID_PTR_INP
87-
self.run_bot()
88-
self.assertMessageEqual(0, INVALID_PTR_OUT)
89-
9077
def test_invalid_ptr2(self):
9178
self.input_message = INVALID_PTR_INP2
9279
self.run_bot()

0 commit comments

Comments
 (0)