Sending to all connected websocket clients

[egnor]

I'd like to be able to broadcast a message to all websocket clients currently connected. I'm thinking this would be something like this

for (struct mg_connection *conn = mgr->conns; conn != NULL; conn = conn->next) {
  if (conn->is_websocket && !conn->is_draining && !conn->is_closing) {
    mg_ws_send(conn, blah blah blah);
  }
}

is that... reasonable? I feel like I'm mucking around in undocumented innards here. Any gotchas?

[scaprile]

Please see our documentation, and follow the guidelines in our tutorials.
There are several tutorials doing that.
https://mongoose.ws/documentation/tutorials/core/timers/#websocket-broadcast

mongoose/tutorials/core/multi-threaded-12m/main.c

Lines 69 to 76 in 793171e

	struct mg_str *data = (struct mg_str *) ev_data;
	// Broadcast message to all connected websocket clients.
	// Traverse over all connections
	for (struct mg_connection *wc = c->mgr->conns; wc != NULL; wc = wc->next) {
	// Send only to marked connections
	if (wc->data[0] == 'W')
	mg_ws_send(wc, data->buf, data->len, WEBSOCKET_OP_TEXT);
	}

[egnor]

Ah I missed that thank you!! Maybe link that in the "WebSockets" section of the tutorials list, I didn't think to look in the "Timers" section!

[scaprile]

That is not a websockets specific action either, is just a way of doing things periodically or on demand, and timers are used to do things periodically and the second example does it on demand.

[egnor]

Yeah I was just thinking it could be linked, it's clearly a timer tutorial mainly. For websockets specifically "send to all" is a common thing one might look for within the websocket interface so a breadcrumb "also see this one" link would be handy. (Your system has the ability to "send to all that you've tagged a certain way" which is even better.)

Just a mild suggestion, thanks for the excellent code-- probably the most well organized straight-C protocol stack implementation I've ever seen, I have no idea how you managed to make it so elegant when most are so encrusted with pseudoabstractions. Kudos!

[scaprile]

I take it, will do.
WRT the code, thanks !