UT fix

Author: cesarParra

src/core/changelog/__test__/processing-changelog.spec.ts

@@ -168,13 +168,16 @@ describe('when generating a changelog', () => {
 
       const changeLog = processChangelog(oldVersion, newVersion);
 
+      // TODO: The changelog should display the old label and the new label
+      // TODO: Same deal with fields
+
       expect(changeLog.customObjectModifications).toEqual([
         {
           typeName: oldObject.name,
           modifications: [
             {
               __typename: 'CustomObjectLabelChanged',
-              name: 'NewLabel',
+              name: newObject.name,
             },
           ],
         },

src/core/changelog/process-changelog.ts

@@ -111,10 +111,10 @@ function getCustomObjectModifications(oldVersion: VersionManifest, newVersion: V
 
 function getModifiedCustomObjectLabels(typesInBoth: TypeInBoth<CustomObjectMetadata>[]): NewOrModifiedMember[] {
   return typesInBoth
-    .filter(({ oldType, newType }) => oldType.label.toLowerCase() !== newType.label.toLowerCase())
+    .filter(({ oldType, newType }) => oldType.label?.toLowerCase() !== newType.label?.toLowerCase())
     .map(({ newType }) => ({
       typeName: newType.name,
-      modifications: [{ __typename: 'CustomObjectLabelChanged', name: newType.label }],
+      modifications: [{ __typename: 'CustomObjectLabelChanged', name: newType.name }],
     }));
 }
 

src/core/reflection/sobject/reflect-custom-object-sources.ts

@@ -59,7 +59,7 @@ function validate(parseResult: unknown): E.Either<Error, { CustomObject: unknown
   return pipe(parseResult, isObject, E.chain(hasTheCustomObjectKey));
 }
 
-function toObjectMetadata(parserResult: { CustomObject: object }): ObjectMetadata {
+function toObjectMetadata(parserResult: { CustomObject: unknown }): CustomObjectMetadata {
   const customObject = typeof parserResult.CustomObject === 'object' ? parserResult.CustomObject : {};
 
   const defaultValues = {
@@ -68,7 +68,7 @@ function toObjectMetadata(parserResult: { CustomObject: object }): ObjectMetadat
     description: null,
     fields: [] as CustomFieldMetadata[],
   };
-  return { ...defaultValues, ...customObject } as ObjectMetadata;
+  return { ...defaultValues, ...customObject } as CustomObjectMetadata;
 }
 
 function addName(objectMetadata: CustomObjectMetadata, name: string): CustomObjectMetadata {