Fixing issue when parsing standard object without the label property

Author: cesarParra

src/core/markdown/adapters/type-to-renderable.ts

@@ -280,7 +280,7 @@ function fieldMetadataToRenderable(
     heading: field.label ?? field.name,
     description: field.description ? [field.description] : [],
     apiName: getApiName(field.name, config),
-    fieldType: field.type ?? '',
+    fieldType: field.type,
   };
 }
 

src/core/markdown/templates/custom-object-template.ts

@@ -19,9 +19,11 @@ export const customObjectTemplate = `
 
 \`{{{apiName}}}\`
 
+{{#if fieldType}}
 **Type**
 
 *{{fieldType}}*
+{{/if}}
 
 {{#unless @last}}---{{/unless}}
 {{/each}}

src/core/reflection/sobject/__test__/reflect-custom-field-sources.spec.ts

@@ -137,66 +137,4 @@ describe('when parsing custom field metadata', () => {
 
     expect(E.isLeft(result)).toBe(true);
   });
-
-  test('An error is returned when the CustomField key is not an object', async () => {
-    const unparsed: UnparsedCustomFieldBundle = {
-      type: 'customfield',
-      name: 'PhotoUrl__c',
-      parentName: 'MyFirstObject__c',
-      filePath: 'src/field/PhotoUrl__c.field-meta.xml',
-      content: `
-      <?xml version="1.0" encoding="UTF-8"?>
-      <CustomField xmlns="http://soap.sforce.com/2006/04/metadata">invalid</CustomField>`,
-    };
-
-    const result = await reflectCustomFieldSources([unparsed])();
-
-    expect(E.isLeft(result)).toBe(true);
-  });
-
-  test('An error is returned when the CustomKey object does not contain the label key', async () => {
-    const unparsed: UnparsedCustomFieldBundle = {
-      type: 'customfield',
-      name: 'PhotoUrl__c',
-      parentName: 'MyFirstObject__c',
-      filePath: 'src/field/PhotoUrl__c.field-meta.xml',
-      content: `
-      <?xml version="1.0" encoding="UTF-8"?>
-      <CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
-          <fullName>PhotoUrl__c</fullName>
-          <externalId>false</externalId>
-          <required>false</required>
-          <trackFeedHistory>false</trackFeedHistory>
-          <type>Url</type>
-          <description>A Photo URL field</description>
-      </CustomField>`,
-    };
-
-    const result = await reflectCustomFieldSources([unparsed])();
-
-    expect(E.isLeft(result)).toBe(true);
-  });
-
-  test('An error is returned when the CustomKey object does not contain the type key', async () => {
-    const unparsed: UnparsedCustomFieldBundle = {
-      type: 'customfield',
-      name: 'PhotoUrl__c',
-      parentName: 'MyFirstObject__c',
-      filePath: 'src/field/PhotoUrl__c.field-meta.xml',
-      content: `
-      <?xml version="1.0" encoding="UTF-8"?>
-      <CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
-          <fullName>PhotoUrl__c</fullName>
-          <externalId>false</externalId>
-          <label>PhotoUrl</label>
-          <required>false</required>
-          <trackFeedHistory>false</trackFeedHistory>
-          <description>A Photo URL field</description>
-      </CustomField>`,
-    };
-
-    const result = await reflectCustomFieldSources([unparsed])();
-
-    expect(E.isLeft(result)).toBe(true);
-  });
 });

src/core/reflection/sobject/__test__/reflect-custom-object-sources.spec.ts

@@ -156,26 +156,4 @@ describe('when parsing SObject metadata', () => {
 
     expect(E.isLeft(result)).toBe(true);
   });
-
-  test('an error is thrown when the label is missing', async () => {
-    const sObjectContent = `
-    <?xml version="1.0" encoding="UTF-8"?>
-    <CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
-        <deploymentStatus>Deployed</deploymentStatus>
-        <description>test object for testing</description>
-        <pluralLabel>MyFirstObjects</pluralLabel>
-        <visibility>Public</visibility>
-    </CustomObject>`;
-
-    const unparsed: UnparsedCustomObjectBundle = {
-      type: 'customobject',
-      name: 'MyFirstObject__c',
-      filePath: 'src/object/MyFirstObject__c.object-meta.xml',
-      content: sObjectContent,
-    };
-
-    const result = await reflectCustomObjectSources([unparsed])();
-
-    expect(E.isLeft(result)).toBe(true);
-  });
 });

src/core/renderables/types.d.ts

@@ -190,7 +190,7 @@ export type RenderableCustomField = {
   apiName: string;
   description: RenderableContent[];
   type: 'field';
-  fieldType: string;
+  fieldType?: string | null;
 };
 
 export type Renderable = (RenderableClass | RenderableInterface | RenderableEnum | RenderableCustomObject) & {