CR updates

Author: cesarParra

examples/vitepress/docs/custom-objects/Price_Component__c.md

@@ -66,4 +66,9 @@ Use this when the Price Component represents a Flat Price. To represent a Percen
 
 **Type**
 
-*Picklist*
+*Picklist*
+
+#### Possible values are
+* List Price
+* Surcharge
+* Discount

examples/vitepress/docs/custom-objects/Sales_Order_Line__c.md

@@ -62,4 +62,8 @@ Represents a line item on a sales order.
 
 **Type**
 
-*Picklist*
+*Picklist*
+
+#### Possible values are
+* Charge
+* Discount

src/core/markdown/adapters/type-to-renderable.ts

@@ -281,13 +281,11 @@ function fieldMetadataToRenderable(
     description: field.description ? [field.description] : [],
     apiName: getApiName(field.name, config),
     fieldType: field.type,
-    isPicklist: field.pickListValues.length > 0,
-    pickListValues: {
+    pickListValues: field.pickListValues ? {
       headingLevel: headingLevel + 1,
       heading: 'Possible values are',
-      value: field.pickListValues
-      
-    }
+      value: field.pickListValues,
+    } : undefined,
   };
 }
 

src/core/markdown/templates/custom-object-template.ts

@@ -24,11 +24,11 @@ export const customObjectTemplate = `
 
 *{{fieldType}}*
 
-{{#if isPicklist}}
-    {{ heading headingLevel heading }}
-    {{#each pickListValues.value}}
-    * {{{this}}}
-    {{/each}}
+{{#if pickListValues}}
+{{ heading pickListValues.headingLevel pickListValues.heading }}
+{{#each pickListValues.value}}
+* {{{this}}}
+{{/each}}
 {{/if}}
 {{/if}}
 

src/core/reflection/sobject/reflect-custom-field-source.ts

@@ -15,7 +15,7 @@ export type CustomFieldMetadata = {
   label?: string | null;
   type?: string | null;
   parentName: string;
-  pickListValues: string[];
+  pickListValues?: string[];
 };
 
 export function reflectCustomFieldSources(
@@ -66,7 +66,7 @@ function toCustomFieldMetadata(parserResult: { CustomField: unknown }): CustomFi
   };
 
   const pickListValues =
-    hasType(customField) && customField.type?.toLowerCase() === 'picklist' ? toPickListValues(customField) : [];
+    hasType(customField) && customField.type?.toLowerCase() === 'picklist' ? toPickListValues(customField) : undefined;
   return { ...defaultValues, ...customField, type_name: 'customfield', pickListValues } as CustomFieldMetadata;
 }
 
@@ -86,7 +86,7 @@ function toPickListValues(customField: object): string[] {
 }
 
 function hasType(customField: object): customField is CustomFieldMetadata {
-  return (customField as CustomFieldMetadata).type != undefined;
+  return !!(customField as CustomFieldMetadata).type;
 }
 
 function addName(metadata: CustomFieldMetadata, name: string): CustomFieldMetadata {

src/core/renderables/types.d.ts

@@ -189,7 +189,6 @@ export type RenderableCustomField = {
   heading: string;
   apiName: string;
   description: RenderableContent[];
-  isPicklist: boolean;
   pickListValues?: RenderableSection<string[]>
   type: 'field';
   fieldType?: string | null;