Uts

Author: cesarParra

src/core/changelog/__test__/processing-changelog.spec.ts

@@ -13,12 +13,19 @@ function apexTypeFromRawString(raw: string): Type {
 }
 
 class CustomFieldMetadataBuilder {
+  name: string = 'MyField';
+
+  withName(name: string): CustomFieldMetadataBuilder {
+    this.name = name;
+    return this;
+  }
+
   build(): CustomFieldMetadata {
     return {
       type: 'Text',
       type_name: 'customfield',
       label: 'MyField',
-      name: 'MyField',
+      name: this.name,
       description: null,
       parentName: 'MyObject',
     };
@@ -29,11 +36,6 @@ class CustomObjectMetadataBuilder {
   label: string = 'MyObject';
   fields: CustomFieldMetadata[] = [];
 
-  withLabel(label: string): CustomObjectMetadataBuilder {
-    this.label = label;
-    return this;
-  }
-
   withField(field: CustomFieldMetadata): CustomObjectMetadataBuilder {
     this.fields.push(field);
     return this;
@@ -570,4 +572,65 @@ describe('when generating a changelog', () => {
       ]);
     });
   });
+
+  describe('with custom field code', () => {
+    it('does not list fields that are the same in both versions', () => {
+      // A field that is the same in both versions is defined as one
+      // with both the same name and the same parent
+
+      const oldField = new CustomFieldMetadataBuilder().build();
+      const newField = new CustomFieldMetadataBuilder().build();
+
+      const oldManifest = { types: [oldField] };
+      const newManifest = { types: [newField] };
+
+      const changeLog = processChangelog(oldManifest, newManifest);
+
+      expect(changeLog.customObjectModifications).toEqual([]);
+    });
+
+    it('lists new fields of a custom object', () => {
+      const oldField = new CustomFieldMetadataBuilder().build();
+      const newField = new CustomFieldMetadataBuilder().withName('NewField').build();
+
+      const oldManifest = { types: [oldField] };
+      const newManifest = { types: [oldField, newField] };
+
+      const changeLog = processChangelog(oldManifest, newManifest);
+
+      expect(changeLog.customObjectModifications).toEqual([
+        {
+          typeName: newField.parentName,
+          modifications: [
+            {
+              __typename: 'NewField',
+              name: newField.name,
+            },
+          ],
+        },
+      ]);
+    });
+
+    it('lists removed fields of a custom object', () => {
+      const oldField = new CustomFieldMetadataBuilder().withName('OldField').build();
+      const unchangedField = new CustomFieldMetadataBuilder().build();
+
+      const oldManifest = { types: [unchangedField, oldField] };
+      const newManifest = { types: [unchangedField] };
+
+      const changeLog = processChangelog(oldManifest, newManifest);
+
+      expect(changeLog.customObjectModifications).toEqual([
+        {
+          typeName: oldField.parentName,
+          modifications: [
+            {
+              __typename: 'RemovedField',
+              name: oldField.name,
+            },
+          ],
+        },
+      ]);
+    });
+  });
 });

src/core/changelog/generate-change-log.ts

@@ -72,7 +72,6 @@ function reflect(bundles: UnparsedSourceBundle[], config: Omit<UserDefinedChange
   );
 }
 
-// TODO: UTs
 function toManifests({ oldVersion, newVersion }: { oldVersion: ParsedFile[]; newVersion: ParsedFile[] }) {
   function parsedFilesToManifest(parsedFiles: ParsedFile[]): VersionManifest {
     return {

src/core/changelog/process-changelog.ts

@@ -109,7 +109,6 @@ function getCustomObjectModifications(oldVersion: VersionManifest, newVersion: V
   );
 }
 
-// TODO: UTs
 function getNewOrModifiedExtensionFields(
   oldVersion: VersionManifest,
   newVersion: VersionManifest,