Refactoring picklist parsing to a generic file for reuse

Author: cesarParra

src/core/reflection/sobject/parse-picklist-values.ts

@@ -0,0 +1,32 @@
+import { CustomFieldMetadata } from './reflect-custom-field-source';
+
+type MaybeTyped = {
+  type?: string;
+};
+
+export function getPickListValues(customField: MaybeTyped): string[] | undefined {
+  return hasType(customField) && isPicklist(customField) ? toPickListValues(customField) : undefined;
+}
+
+function hasType(customField: MaybeTyped): customField is { type: string } {
+  return !!(customField as CustomFieldMetadata).type;
+}
+
+function isPicklist(typedCustomField: { type: string }) {
+  return typedCustomField.type.toLowerCase() === 'picklist';
+}
+
+function toPickListValues(customField: MaybeTyped): string[] | undefined {
+  if ('valueSet' in customField) {
+    const valueSet = customField.valueSet as object;
+    if ('valueSetDefinition' in valueSet) {
+      const valueSetDefinition = valueSet.valueSetDefinition as object;
+      if ('value' in valueSetDefinition) {
+        const pickListValues = valueSetDefinition.value as object[];
+        return pickListValues.filter((each) => 'fullName' in each).map((each) => each.fullName as string);
+      }
+    }
+  }
+
+  return undefined;
+}

src/core/reflection/sobject/reflect-custom-field-source.ts

@@ -7,6 +7,7 @@ import { pipe } from 'fp-ts/function';
 import * as A from 'fp-ts/Array';
 import { XMLParser } from 'fast-xml-parser';
 import * as E from 'fp-ts/Either';
+import { getPickListValues } from './parse-picklist-values';
 
 export type CustomFieldMetadata = {
   type_name: 'customfield';
@@ -65,28 +66,12 @@ function toCustomFieldMetadata(parserResult: { CustomField: unknown }): CustomFi
     description: null,
   };
 
-  const pickListValues =
-    hasType(customField) && customField.type.toLowerCase() === 'picklist' ? toPickListValues(customField) : undefined;
-  return { ...defaultValues, ...customField, type_name: 'customfield', pickListValues } as CustomFieldMetadata;
-}
-
-function toPickListValues(customField: object): string[] {
-  if ('valueSet' in customField) {
-    const valueSet = customField.valueSet as object;
-    if ('valueSetDefinition' in valueSet) {
-      const valueSetDefinition = valueSet.valueSetDefinition as object;
-      if ('value' in valueSetDefinition) {
-        const pickListValues = valueSetDefinition.value as object[];
-        return pickListValues.filter((each) => 'fullName' in each).map((each) => each.fullName as string);
-      }
-    }
-  }
-
-  return [];
-}
-
-function hasType(customField: object): customField is { type: string } {
-  return !!(customField as CustomFieldMetadata).type;
+  return {
+    ...defaultValues,
+    ...customField,
+    type_name: 'customfield',
+    pickListValues: getPickListValues(customField),
+  } as CustomFieldMetadata;
 }
 
 function addName(metadata: CustomFieldMetadata, name: string): CustomFieldMetadata {