Skip to content

Commit c42fae2

Browse files
committed
UT refactoring
1 parent 2723bd8 commit c42fae2

File tree

8 files changed

+38
-42
lines changed

8 files changed

+38
-42
lines changed

examples/changelog/docs/changelog.md

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,21 @@ These members have been added or modified.
4949
### SolidService
5050

5151
- New Method: newMethod
52-
- Removed Method: deprecatedMethod
52+
- Removed Method: deprecatedMethod
53+
54+
## New or Removed Fields in Existing Objects
55+
56+
These custom fields have been added or removed.
57+
58+
### Event__c
59+
60+
- New Field: Description__c
61+
- New Field: Tag_Line__c
62+
63+
### Price_Component__c
64+
65+
- New Field: Description__c
66+
67+
### Product__c
68+
69+
- New Field: Description__c

src/core/changelog/__test__/generating-change-log.spec.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
import { ChangeLogPageData, generateChangeLog } from '../generate-change-log';
88
import { assertEither } from '../../test-helpers/assert-either';
99
import { isSkip } from '../../shared/utils';
10+
import { customObjectGenerator } from '../../test-helpers/test-data-builders';
1011

1112
const config = {
1213
fileName: 'changelog',
@@ -18,20 +19,6 @@ const config = {
1819
skipIfNoChanges: false,
1920
};
2021

21-
function customObjectGenerator(
22-
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
23-
) {
24-
return `
25-
<?xml version="1.0" encoding="UTF-8"?>
26-
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
27-
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
28-
<description>test object for testing</description>
29-
<label>MyTestObject</label>
30-
<pluralLabel>MyFirstObjects</pluralLabel>
31-
<visibility>${config.visibility}</visibility>
32-
</CustomObject>`;
33-
}
34-
3522
export const customField = `
3623
<?xml version="1.0" encoding="UTF-8"?>
3724
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">

src/core/changelog/templates/changelog-template.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export const changelogTemplate = `
9494
{{#each this.modifications}}
9595
- {{this}}
9696
{{/each}}
97+
9798
{{/each}}
9899
{{/if}}
99100
`.trim();

src/core/markdown/__test__/generating-custom-object-docs.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { extendExpect } from './expect-extensions';
22
import {
33
customField,
4-
customObjectGenerator,
54
generateDocs,
65
unparsedFieldBundleFromRawString,
76
unparsedObjectBundleFromRawString,
87
} from './test-helpers';
98
import { assertEither } from '../../test-helpers/assert-either';
9+
import { customObjectGenerator } from '../../test-helpers/test-data-builders';
1010

1111
describe('Generates Custom Object documentation', () => {
1212
beforeAll(() => {

src/core/markdown/__test__/generating-docs.spec.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
import { DocPageData, PostHookDocumentationBundle } from '../../shared/types';
22
import { extendExpect } from './expect-extensions';
3-
import {
4-
unparsedApexBundleFromRawString,
5-
generateDocs,
6-
unparsedObjectBundleFromRawString,
7-
customObjectGenerator,
8-
} from './test-helpers';
3+
import { unparsedApexBundleFromRawString, generateDocs, unparsedObjectBundleFromRawString } from './test-helpers';
94
import { assertEither } from '../../test-helpers/assert-either';
5+
import { customObjectGenerator } from '../../test-helpers/test-data-builders';
106

117
function aSingleDoc(result: PostHookDocumentationBundle): DocPageData {
128
expect(result.docs).toHaveLength(1);

src/core/markdown/__test__/generating-reference-guide.spec.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
import { extendExpect } from './expect-extensions';
22
import { pipe } from 'fp-ts/function';
33
import * as E from 'fp-ts/Either';
4-
import {
5-
unparsedApexBundleFromRawString,
6-
generateDocs,
7-
customObjectGenerator,
8-
unparsedObjectBundleFromRawString,
9-
} from './test-helpers';
4+
import { unparsedApexBundleFromRawString, generateDocs, unparsedObjectBundleFromRawString } from './test-helpers';
105
import { ReferenceGuidePageData } from '../../shared/types';
116
import { assertEither } from '../../test-helpers/assert-either';
7+
import { customObjectGenerator } from '../../test-helpers/test-data-builders';
128

139
describe('When generating the Reference Guide', () => {
1410
beforeAll(() => {

src/core/markdown/__test__/test-helpers.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,20 +59,6 @@ export function generateDocs(apexBundles: UnparsedSourceBundle[], config?: Parti
5959
});
6060
}
6161

62-
export function customObjectGenerator(
63-
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
64-
) {
65-
return `
66-
<?xml version="1.0" encoding="UTF-8"?>
67-
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
68-
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
69-
<description>test object for testing</description>
70-
<label>MyTestObject</label>
71-
<pluralLabel>MyFirstObjects</pluralLabel>
72-
<visibility>${config.visibility}</visibility>
73-
</CustomObject>`;
74-
}
75-
7662
export const customField = `
7763
<?xml version="1.0" encoding="UTF-8"?>
7864
<CustomField xmlns="http://soap.sforce.com/2006/04/metadata">
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
export function customObjectGenerator(
2+
config: { deploymentStatus: string; visibility: string } = { deploymentStatus: 'Deployed', visibility: 'Public' },
3+
) {
4+
return `
5+
<?xml version="1.0" encoding="UTF-8"?>
6+
<CustomObject xmlns="http://soap.sforce.com/2006/04/metadata">
7+
<deploymentStatus>${config.deploymentStatus}</deploymentStatus>
8+
<description>test object for testing</description>
9+
<label>MyTestObject</label>
10+
<pluralLabel>MyFirstObjects</pluralLabel>
11+
<visibility>${config.visibility}</visibility>
12+
</CustomObject>`;
13+
}

0 commit comments

Comments
 (0)