added lombok features. :))

Author: cevheri

person-service/src/main/java/com/cevher/ms/person/domain/Person.java

@@ -1,17 +1,19 @@
 package com.cevher.ms.person.domain;
 
 
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.NoArgsConstructor;
+import lombok.*;
 
 import javax.persistence.Entity;
 import javax.persistence.GeneratedValue;
 import javax.persistence.GenerationType;
 import javax.persistence.Id;
 
 @Entity
-@Data
+@Getter
+@Setter
+@ToString
+@Builder
+@EqualsAndHashCode
 @AllArgsConstructor
 @NoArgsConstructor
 public class Person {

person-service/src/main/java/com/cevher/ms/person/repository/PersonRepository.java

@@ -6,7 +6,6 @@
 
 import java.util.Optional;
 
-@Repository
 public interface PersonRepository extends JpaRepository<Person, Long> {
     Optional<Person> findById(Long id);
 }

person-service/src/main/java/com/cevher/ms/person/service/PersonService.java

@@ -4,7 +4,9 @@
 import com.cevher.ms.person.repository.PersonRepository;
 import com.cevher.ms.person.vm.DepartmentVM;
 import com.cevher.ms.person.vm.ResponseTempVM;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
+import lombok.val;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.web.client.RestTemplate;
@@ -13,11 +15,10 @@
 
 @Service
 @Slf4j
+@RequiredArgsConstructor
 public class PersonService {
-    @Autowired
-    private PersonRepository personRepository;
 
-    @Autowired
+    private PersonRepository personRepository;
     private RestTemplate restTemplate;
 
     public Person savePerson(Person person) {
@@ -28,18 +29,18 @@ public Person savePerson(Person person) {
     public ResponseTempVM getPersonWithDepartment(Long personId) {
         log.info("getPersonWithDepartment method of PersonService");
 
-        ResponseTempVM vm = new ResponseTempVM();
-        Person person = personRepository.findById(personId).orElse(new Person());
+        val person = personRepository.findById(personId).orElse(new Person());
 
         // TODO : not for production, you should use config and common class or method.
         // TODO : We can use Message Broker for example Apache Kafka
-        DepartmentVM department = restTemplate.getForObject(
-                "http://department-service/departments/" + person.getDepartmentId()
-                , DepartmentVM.class);
-
-        vm.setPerson(person);
-        vm.setDepartment(department);
-        return vm;
+        val url = "http://department-service/departments/" + person.getDepartmentId();
+        val department = restTemplate.getForObject(url, DepartmentVM.class);
+
+        return ResponseTempVM
+                .builder()
+                .person(person)
+                .department(department)
+                .build();
     }
 
     public List<Person> findAllPerson() {

person-service/src/main/java/com/cevher/ms/person/vm/DepartmentVM.java

@@ -1,10 +1,12 @@
 package com.cevher.ms.person.vm;
 
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.NoArgsConstructor;
+import lombok.*;
 
-@Data
+@Getter
+@Setter
+@ToString
+@Builder
+@EqualsAndHashCode
 @AllArgsConstructor
 @NoArgsConstructor
 public class DepartmentVM {

person-service/src/main/java/com/cevher/ms/person/vm/ResponseTempVM.java

@@ -1,11 +1,13 @@
 package com.cevher.ms.person.vm;
 
 import com.cevher.ms.person.domain.Person;
-import lombok.AllArgsConstructor;
-import lombok.Data;
-import lombok.NoArgsConstructor;
+import lombok.*;
 
-@Data
+@Getter
+@Setter
+@ToString
+@Builder
+@EqualsAndHashCode
 @AllArgsConstructor
 @NoArgsConstructor
 public class ResponseTempVM {

person-service/src/main/java/com/cevher/ms/person/web/rest/PersonController.java

@@ -3,6 +3,7 @@
 import com.cevher.ms.person.domain.Person;
 import com.cevher.ms.person.service.PersonService;
 import com.cevher.ms.person.vm.ResponseTempVM;
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.web.bind.annotation.*;
@@ -12,9 +13,9 @@
 @RestController
 @RequestMapping("/people")
 @Slf4j
+@RequiredArgsConstructor
 public class PersonController {
 
-    @Autowired
     private PersonService personService;
 
     @PostMapping("/")