Conformance requirement on actual_range
#408
Replies: 12 comments 16 replies
-
But doesn't this in the end equals to the same statement ? |
Beta Was this translation helpful? Give feedback.
-
Something's not right in the 2.5.1: The text says that Either |
Beta Was this translation helpful? Give feedback.
-
Considering that
This still leaves open the inconsistency with the conformance requirements. |
Beta Was this translation helpful? Give feedback.
-
Hi Patrick, I think that's nearly it, but when data are packed then the I'm thinking that the reference to
With this, the conformance would some changes, but I don't have time to suggest those right now :) |
Beta Was this translation helpful? Give feedback.
-
Hi all - The phrase "must be exactly equal" caught my eye. Given there's floating point math involved, it seems potentially problematic. |
Beta Was this translation helpful? Give feedback.
-
Does anyone know what the use case is for I ask because one way to resolve the issue would be to deprecate That's an extreme measure, but I think it's worth considering, because there's a really big problem with Because they are supposed to be "exactly equal to the minimum and the maximum of the non-missing data values," any time that there's a change to the data, the min and max could change, so you should be recomputing them and updating the attribute. But nobody does that. In particular, nobody does it because (unless I've missed something) none of the major software packages that people use to process netcdf files (NCO, CDO, xarray) support automatic updating of the attribute, and nobody is going to do that update by hand every time that they touch a file. Which means that, of all the files out there in the world that have an Alternately, if it useful to keep around, we could resolve both issues by loosening the requirements, and defining it simply as a range that's appropriate to use for visualization of the data (or whatever other use case may apply), without specifying its type or value. |
Beta Was this translation helpful? Give feedback.
-
well, true, but this is not the same as most other cases, because:
Which means they are a calculated value, from the data itself. It's a good practice in software to NOT store explicitly a calculated value separately, because it's too easy for it to get out of sync. So why does this attribute exist?
But in that case, to @sethmcg 's point, perhaps we could relax the constraint to: It is recommended that the range be: exactly equal to the minimum and the maximum of the non-missing data values And it is required that the range: encompass the full range of the the non-missing data values. All the being said, the language should still be correct and clear with regard to the data types :-) |
Beta Was this translation helpful? Give feedback.
-
well, yeah -- "actual" does have a meaning .... however, it is used as an addendum to:
So so does "actual" mean : what's in this exact variable, right now? (the current definition) or what might actually be stored in this variable from this source. In a way, the second definition seem more useful to me: When writing code to process the data -- you need to decide what data types to use, what values to use as ranges fro plotting, etc. And for that, you want to know what the range is of values one might expect for this variable in general, not necessarily what the range is for this particular subset. I guess what I'm getting at is that it is very common for the same type( source, etc) oof data to be presented in multiple files -- spanning time periods, or what have you. IN that case, it seems lot less useful for each file to have an exactly computer Does anyone remember what the original use case was for |
Beta Was this translation helpful? Give feedback.
-
Thanks! Then my point stands -- the "range of values you might get in this variable" rather than "the range of values this particular variable contains" is far more useful. Of course, this would a potentially breaking change :-( -CHB |
Beta Was this translation helpful? Give feedback.
-
I note, with certain amusement, that a rather mundane flagging of an inconsistency between two documents is evolving into a discussion on what the conventions should or should not include, which involves digging up 10-yo trac tickets. Great research work, Seth! If there were such a position, I would move to appoint you Chief Custodian of the Conventions. That said, two things.
Which brings me to, for good measure, 3. The attribute So I commiserate with Seth and Chris on the plight of having to work with bad software and sloppy data scientists, but I suggest that you disregard the |
Beta Was this translation helpful? Give feedback.
-
Basically, I agree with all of the above. But a different question is what does the Instead, when my single variable now is split up into several files it seems reasonable to make the On the other hand, as CMIP and CORDEX files are split into consistent time periods, wouldn't it be reasonable to have one I imagine that these questions may have very clear answers --- that may be very different depending on who you ask... I.e. no clear answer.... One thing is that we of course should clear up the inconsistency that Paul initially pointed at. Another thing is that now, when the cat is out of the bag, we should as well clarify what |
Beta Was this translation helpful? Give feedback.
-
Coming back to the initial issue: there is an obvious discrepancy between the conventions and the conformance document. On 24 March @davidhassell proposed the following text for the conventions, section 2.5.1:
"Variables containing numeric data" includes more than the currently allowed (Appendix A) coordinate variables, data variables and boundary variables: cell measure variables, auxiliary lat-long grids, geometry containers all contain numeric data as well. I would therefore suggest to qualify that phrase to be more specific. In terms of changes to the conformance document, I would propose the following:
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Topic for discussion
In the conventions, section 2.5.1, it is stated:
The conformance requirements for the same state:
This is obviously a mistake in the conformance document.
Beta Was this translation helpful? Give feedback.
All reactions