Skip to content

Commit 41bb8ae

Browse files
committed
Added mingw to platforms where we build libiconv
Adding libiconv for mingw platform as our build host ubuntu-16 lacks the win-iconv-mingw-w64-dev package. If we upgrade our build host to ubuntu-20 or newer we can rely on that system package instead. Ticket: ENT-12744 Changelog: none
1 parent 028e32a commit 41bb8ae

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

build-scripts/compile-options

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,10 @@ case "$OS_FAMILY" in
123123
esac
124124

125125
# iconv is needed for libxml2 on some platforms
126+
# ENT-12744 - adding libiconv for mingw platform as our build host ubuntu-16 lacks the win-iconv-mingw-w64-dev package.
127+
# If we upgrade our build host to ubuntu-20 or newer we can rely on that system package instead.
126128
case "$OS_FAMILY" in
127-
aix|solaris) var_append DEPS "libiconv" ;;
129+
mingw|aix|solaris) var_append DEPS "libiconv" ;;
128130
esac
129131

130132
var_append DEPS "libxml2 libyaml"

0 commit comments

Comments
 (0)