transfer-to-testmachine: fixed shellcheck issues

Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>

Author: larsewi

build-scripts/transfer-to-testmachine

@@ -1,6 +1,6 @@
 #!/bin/sh -x
 
-. $(dirname "$0")/functions
+. "$(dirname "$0")"/functions
 . detect-environment
 . compile-options
 
@@ -25,12 +25,22 @@ esac
 # This way we avoid errorneously replacing "/." in the
 # middle of BASEDIR like "/home/jenkins/.jenkinsdir/etc"
 # (Google Cloud Jenkins plugin likes to create them)
-BASEDIR_NO_DOT="$(echo $BASEDIR | sed -e 's,/\./,/,g;s,/\.$,,')"
+BASEDIR_NO_DOT="$(echo "$BASEDIR" | sed -e 's,/\./,/,g;s,/\.$,,')"
 touch .keepalive-echo
 (while test -e .keepalive-echo; do
     sleep 60
     echo Keep alive
 done) &
+
+# shellcheck disable=SC2086
+# > Double quote to prevent globbing and word splitting.
+# We want word splitting here
+
+# shellcheck disable=SC2024
+# > sudo doesn't affect redirects. Use ..| sudo tee file
+# We don't care
 sudo rsync -avR $EXCLUDES --delete --delete-excluded "$BASEDIR_NO_DOT/" $TESTMACHINE_URI >/tmp/rsync.log
+# shellcheck disable=SC2086
+# shellcheck disable=SC2024
 sudo rsync -avR $EXCLUDES --delete --delete-excluded "$PREFIX/" $TESTMACHINE_URI >>/tmp/rsync.log
 rm .keepalive-echo