Add shell test for format --line-length subcommand

Author: moschlar

src/cfengine_cli/main.py

@@ -43,9 +43,7 @@ def _get_arg_parser():
     subp.add_parser("deploy", help="Deploy a built policy set")
     fmt = subp.add_parser("format", help="Autoformat .json and .cf files")
     fmt.add_argument("files", nargs="*", help="Files to format")
-    fmt.add_argument(
-        "--line-length", default=80, type=int, help="Maximum line length"
-    )
+    fmt.add_argument("--line-length", default=80, type=int, help="Maximum line length")
     subp.add_parser(
         "lint",
         help="Look for syntax errors and other simple mistakes",

tests/shell/003-format.sh

@@ -0,0 +1,37 @@
+#!/bin/bash
+
+set -e
+set -x
+
+# Verify that the line length parameter shows up in help
+cfengine format -h | grep -- "--line-length"
+
+# Test three common line length
+for ll in 80 100 120; do
+	# Format the following HEREDOC and let wc count the longest line
+	l=$(cfengine format --line-length $ll - <<-EOF |
+	bundle agent slists
+	{
+	vars:
+	"variable_name"
+	slist => { "one", "two", "three", "four", "five", "six" };
+	"variable_name"
+	slist => { "one", "two", "three", "four", "five", "six", "seven" };
+	"variable_name"
+	slist => {
+	"one", "two", "three", "four", "five", "six", "seven", "eight"
+	};
+	"variable_name"
+	slist => {
+	"one","two","three","four","five","six","seven","eight","nine","ten","eleven","twelve","thirteen",
+	};
+	"variable_name"
+	slist => {
+	"one","two","three","four","five","six","seven","eight","nine","ten","eleven","twelve","thirteen","fourteen","fifteen","sixteen","seventeen"
+	};
+	}
+	EOF
+	wc -L)
+	# Verify that the actual longest line has less or equal characters
+	[[ $l -le $ll ]]
+done