Merge pull request #6 from cfhamlet/develop

add: choice reactor

Author: cfhamlet

README.md

@@ -31,12 +31,34 @@ os-scrapy -h
 
 ### CRAWLER_CLASS
 
-os-scrapy support config ``CRAWLER_CLASS`` replace the default ``scrapy.crawler.Crawler``. It can be configured in ``settings.py`` file or ``os-scrapy crawl -c <your_crawler_class> <spider_name>``
+os-scrapy support config ``CRAWLER_CLASS`` replace the default ``scrapy.crawler.Crawler``
 
+It can be configured in ``settings.py`` file or command line
 
-## Enhanced ``startproject``
 
-Thanks to [os-scrapy-cookiecutter](https://github.com/cfhamlet/os-scrapy-cookiecutter) a ``-p`` option can be used ``os-scrapy startproject -p <project_name>``, which indicate create project as well as python package. 
+```
+os-scrapy crawl -c <your_crawler_class> <spider_name>
+```
+
+
+### Enhanced ``startproject``
+
+Thanks to [os-scrapy-cookiecutter](https://github.com/cfhamlet/os-scrapy-cookiecutter),  ``-p`` option can be used to create project as well as python package
+
+
+```
+os-scrapy startproject -p <project_name> [project_dir]
+```
+
+### Set ``TWISTED_REACTOR`` on command line
+
+
+``-r`` option can be used to set ``TWISTED_REACTOR``
+
+
+```
+os-scrapy crawl -r asyncio <spider_name>
+```
 
 
 ## Unit Tests
@@ -48,3 +70,4 @@ tox
 ## License
 
 MIT licensed.
+

src/os_scrapy/VERSION

@@ -1 +1 @@
-0.0.3
+0.0.4

src/os_scrapy/commands/crawl.py

@@ -19,6 +19,21 @@ def load_crawler_class(class_path):
 
 DEFAULT_CRAWLER_CLASS = f"{Crawler.__module__}.{Crawler.__name__}"
 
+REACTORS = {
+    "twisted": lambda settings: settings.set("TWISTED_REACTOR", None, "command"),
+    "poll": lambda settings: settings.set(
+        "TWISTED_REACTOR", "twisted.internet.pollreactor.PollReactor", "command"
+    ),
+    "select": lambda settings: settings.set(
+        "TWISTED_REACTOR", "twisted.internet.selectreactor.SelectReactor", "command"
+    ),
+    "asyncio": lambda settings: settings.set(
+        "TWISTED_REACTOR",
+        "twisted.internet.asyncioreactor.AsyncioSelectorReactor",
+        "command",
+    ),
+}
+
 
 class Command(ScrapyCommand):
     default_settings = {
@@ -31,13 +46,25 @@ def add_options(self, parser):
             "-c",
             "--crawler-class",
             metavar="CRAWLER_CLASS",
-            help=f"set crawler class. default {DEFAULT_CRAWLER_CLASS}",
+            help=f"set crawler class (default: {self.settings['CRAWLER_CLASS']})",
+        )
+        reactor = self.settings.get("TWISTED_REACTOR")
+        reactor_choices = list(REACTORS.keys())
+        parser.add_option(
+            "-r",
+            "--reactor",
+            metavar="REACTOR",
+            type="choice",
+            choices=reactor_choices,
+            help=f"reactor type (default: {reactor if reactor else 'twisted'}). choices: {reactor_choices}",
         )
 
     def process_options(self, args, opts):
         super(Command, self).process_options(args, opts)
         if opts.crawler_class:
             self.settings.set("CRAWLER_CLASS", opts.crawler_class, "cmdline")
+        if opts.reactor:
+            REACTORS[opts.reactor](self.settings)
 
     def _create_crawler(self, spname):
         c = self.settings.get("CRAWLER_CLASS")