Skip to content

Commit 9f773fc

Browse files
uemanAlexV525
ueman
and
AlexV525
authored
Fix lint issues (#2006)
Fix lint issues from https://github.com/cfug/dio/actions/runs/6599112276/job/17927803638?pr=2005 --------- Signed-off-by: Jonas Uekötter <ueman@users.noreply.github.com> Co-authored-by: Alex Li <github@alexv525.com>
1 parent fad3fb8 commit 9f773fc

File tree

7 files changed

+58
-56
lines changed

7 files changed

+58
-56
lines changed

‎.github/workflows/tests.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,6 @@ jobs:
144144
uses: subosito/flutter-action@v2.8.0
145145
with:
146146
cache: true
147-
flutter-version: ${{ matrix.channel == 'min' && '3.10.0' || '' }}
147+
flutter-version: ${{ matrix.channel == 'min' && '3.13.0' || '' }}
148148
channel: ${{ matrix.channel == 'min' && 'stable' || matrix.channel }}
149149
- run: flutter test

‎dio/lib/src/compute/compute.dart‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,25 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
/// This file corresponds to Flutter's
6-
/// [`foundation/isolates.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/isolates.dart).
7-
///
8-
/// Changes are only synced with the `stable` branch.
9-
///
10-
/// Last synced commit:
11-
/// [3d46ab9](https://github.com/flutter/flutter/commit/3d46ab920b47a2ecb250c6f890f3559ef913cb0b)
12-
///
13-
/// The changes are currently manually synced. If you noticed that the Flutter's
14-
/// original `compute` function (and any of the related files) have changed
15-
/// on the `stable` branch and you would like to see those changes in the `compute` package
16-
/// please open an [issue](https://github.com/dartsidedev/compute/issues),
17-
/// and I'll try my best to "merge".
18-
///
19-
/// The file is intentionally not refactored so that it is easier to keep the
20-
/// compute package up to date with Flutter's implementation.
21-
///
22-
/// When this library supports just Dart 3, we can delete most of this code
23-
/// an make use of `Isolate.run()`
5+
// This file corresponds to Flutter's
6+
// [`foundation/isolates.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/isolates.dart).
7+
//
8+
// Changes are only synced with the `stable` branch.
9+
//
10+
// Last synced commit:
11+
// [3d46ab9](https://github.com/flutter/flutter/commit/3d46ab920b47a2ecb250c6f890f3559ef913cb0b)
12+
//
13+
// The changes are currently manually synced. If you noticed that the Flutter's
14+
// original `compute` function (and any of the related files) have changed
15+
// on the `stable` branch and you would like to see those changes in the `compute` package
16+
// please open an [issue](https://github.com/dartsidedev/compute/issues),
17+
// and I'll try my best to "merge".
18+
//
19+
// The file is intentionally not refactored so that it is easier to keep the
20+
// compute package up to date with Flutter's implementation.
21+
//
22+
// When this library supports just Dart 3, we can delete most of this code
23+
// an make use of `Isolate.run()`
2424
// ignore_for_file: no_leading_underscores_for_library_prefixes
2525

2626
import 'dart:async';

‎dio/lib/src/compute/compute_io.dart‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
/// This file corresponds to Flutter's
6-
/// [`foundation/_isolates_io.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/_isolates_io.dart).
7-
///
8-
/// Changes are only synced with the `stable` branch.
9-
///
10-
/// Last synced commit:
11-
/// [3420b9c](https://github.com/flutter/flutter/commit/3420b9c50ea19489dd74b024705bb010c5763d0a)
12-
///
13-
/// The changes are currently manually synced. If you noticed that the Flutter's
14-
/// original `compute` function (and any of the related files) have changed
15-
/// on the `stable` branch and you would like to see those changes in the `compute` package
16-
/// please open an [issue](https://github.com/dartsidedev/compute/issues),
17-
/// and I'll try my best to "merge".
18-
///
19-
/// The file is intentionally not refactored so that it is easier to keep the
20-
/// compute package up to date with Flutter's implementation.
5+
// This file corresponds to Flutter's
6+
// [`foundation/_isolates_io.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/_isolates_io.dart).
7+
//
8+
// Changes are only synced with the `stable` branch.
9+
//
10+
// Last synced commit:
11+
// [3420b9c](https://github.com/flutter/flutter/commit/3420b9c50ea19489dd74b024705bb010c5763d0a)
12+
//
13+
// The changes are currently manually synced. If you noticed that the Flutter's
14+
// original `compute` function (and any of the related files) have changed
15+
// on the `stable` branch and you would like to see those changes in the `compute` package
16+
// please open an [issue](https://github.com/dartsidedev/compute/issues),
17+
// and I'll try my best to "merge".
18+
//
19+
// The file is intentionally not refactored so that it is easier to keep the
20+
// compute package up to date with Flutter's implementation.
2121
import 'dart:async';
2222
import 'dart:developer';
2323
import 'dart:isolate';

‎dio/lib/src/compute/compute_web.dart‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
/// This file corresponds to Flutter's
6-
/// [`foundation/_isolates_web.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/_isolates_web.dart).
7-
///
8-
/// Changes are only synced with the `stable` branch.
9-
///
10-
/// Last synced commit:
11-
/// [978a2e7](https://github.com/flutter/flutter/commit/978a2e7bf6a2ed287130af8dbd94cef019fb7bef)
12-
///
13-
/// The changes are currently manually synced. If you noticed that the Flutter's
14-
/// original `compute` function (and any of the related files) have changed
15-
/// on the `stable` branch and you would like to see those changes in the `compute` package
16-
/// please open an [issue](https://github.com/dartsidedev/compute/issues),
17-
/// and I'll try my best to "merge".
18-
///
19-
/// The file is intentionally not refactored so that it is easier to keep the
20-
/// compute package up to date with Flutter's implementation.
5+
// This file corresponds to Flutter's
6+
// [`foundation/_isolates_web.dart`](https://github.com/flutter/flutter/blob/stable/packages/flutter/lib/src/foundation/_isolates_web.dart).
7+
//
8+
// Changes are only synced with the `stable` branch.
9+
//
10+
// Last synced commit:
11+
// [978a2e7](https://github.com/flutter/flutter/commit/978a2e7bf6a2ed287130af8dbd94cef019fb7bef)
12+
//
13+
// The changes are currently manually synced. If you noticed that the Flutter's
14+
// original `compute` function (and any of the related files) have changed
15+
// on the `stable` branch and you would like to see those changes in the `compute` package
16+
// please open an [issue](https://github.com/dartsidedev/compute/issues),
17+
// and I'll try my best to "merge".
18+
//
19+
// The file is intentionally not refactored so that it is easier to keep the
20+
// compute package up to date with Flutter's implementation.
2121
import 'compute.dart' as c;
2222

2323
/// The dart:html implementation of [c.compute].

‎plugins/native_dio_adapter/CHANGELOG.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
## Unreleased
44

55
- Bump `cronet_http` version.
6+
- Minimal required Dart version is now 3.1.
7+
- Minimal required Flutter version is now 3.13.0.
68

79
## 1.0.0+2
810

‎plugins/native_dio_adapter/example/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ publish_to: 'none'
44
version: 1.0.0+1
55

66
environment:
7-
sdk: '>=2.18.0 <3.0.0'
7+
sdk: '>=3.1.0 <4.0.0'
88

99
dependencies:
1010
flutter:
1111
sdk: flutter
1212
cupertino_icons: ^1.0.2
13-
dio: ^5.0.0-0
13+
dio: ^5.0.0
1414
native_dio_adapter:
1515
path:
1616
../

‎plugins/native_dio_adapter/pubspec.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ repository: https://github.com/cfug/dio/blob/main/plugins/native_dio_adapter
1313
issue_tracker: https://github.com/cfug/dio/issues
1414

1515
environment:
16-
sdk: ">=3.0.0 <4.0.0"
17-
flutter: ">=3.10.0"
16+
sdk: ">=3.1.0 <4.0.0"
17+
flutter: ">=3.13.0"
1818

1919
dependencies:
2020
dio: ^5.2.0

0 commit comments

Comments
 (0)