Merge pull request #26 from Hailios/added_move

use move when parameters are passed by value and only copied once

Author: scheibel

AUTHORS

@@ -7,3 +7,4 @@ Willy Scheibel <[email protected]> <[email protected]>
 Thanks to all Contributors:
 
 Robert Bielik (https://github.com/robiwano)
+Hailios (https://github.com/Hailios)

source/cppfs/source/FileHandle.cpp

@@ -124,13 +124,13 @@ std::vector<std::string> FileHandle::listFiles() const
 
 void FileHandle::traverse(VisitFunc funcFileEntry)
 {
-    FunctionalFileVisitor visitor(funcFileEntry);
+    FunctionalFileVisitor visitor(std::move(funcFileEntry));
     traverse(visitor);
 }
 
 void FileHandle::traverse(VisitFunc funcFile, VisitFunc funcDirectory)
 {
-    FunctionalFileVisitor visitor(funcFile, funcDirectory);
+    FunctionalFileVisitor visitor(std::move(funcFile), std::move(funcDirectory));
     traverse(visitor);
 }
 

source/cppfs/source/FileWatcher.cpp

@@ -89,7 +89,7 @@ void FileWatcher::addHandler(FileEventHandler * eventHandler)
 void FileWatcher::addHandler(EventFunc funcFileEvent)
 {
     // Create event handler
-    auto ptr = std::unique_ptr<FunctionalFileEventHandler>(new FunctionalFileEventHandler(funcFileEvent));
+    auto ptr = std::unique_ptr<FunctionalFileEventHandler>(new FunctionalFileEventHandler(std::move(funcFileEvent)));
 
     // Register event handler
     addHandler(ptr.get());

source/cppfs/source/FunctionalFileEventHandler.cpp

@@ -11,7 +11,7 @@ FunctionalFileEventHandler::FunctionalFileEventHandler()
 }
 
 FunctionalFileEventHandler::FunctionalFileEventHandler(EventFunc funcFileEvent)
-: m_funcFileEvent(funcFileEvent)
+: m_funcFileEvent(std::move(funcFileEvent))
 {
 }
 

source/cppfs/source/FunctionalFileVisitor.cpp

@@ -13,13 +13,13 @@ FunctionalFileVisitor::FunctionalFileVisitor()
 }
 
 FunctionalFileVisitor::FunctionalFileVisitor(VisitFunc funcFileEntry)
-: m_funcFileEntry(funcFileEntry)
+: m_funcFileEntry(std::move(funcFileEntry))
 {
 }
 
 FunctionalFileVisitor::FunctionalFileVisitor(VisitFunc funcFile, VisitFunc funcDirectory)
-: m_funcFile(funcFile)
-, m_funcDirectory(funcDirectory)
+: m_funcFile(std::move(funcFile))
+, m_funcDirectory(std::move(funcDirectory))
 {
 }
 

source/cppfs/source/linux/LocalFileWatcher.cpp

@@ -20,7 +20,7 @@ namespace cppfs
 
 LocalFileWatcher::LocalFileWatcher(FileWatcher * fileWatcher, std::shared_ptr<LocalFileSystem> fs)
 : AbstractFileWatcherBackend(fileWatcher)
-, m_fs(fs)
+, m_fs(std::move(fs))
 , m_inotify(-1)
 {
     // Create inotify instance

source/cppfs/source/posix/LocalFileHandle.cpp

@@ -18,12 +18,12 @@ namespace cppfs
 
 
 LocalFileHandle::LocalFileHandle(std::shared_ptr<LocalFileSystem> fs, const std::string & path)
-: LocalFileHandle(fs, std::string(path))
+: LocalFileHandle(std::move(fs), std::string(path))
 {
 }
 
 LocalFileHandle::LocalFileHandle(std::shared_ptr<LocalFileSystem> fs, std::string && path)
-: m_fs(fs)
+: m_fs(std::move(fs))
 , m_path(path)
 , m_fileInfo(nullptr)
 , m_linkInfo(nullptr)

source/cppfs/source/posix/LocalFileIterator.cpp

@@ -12,12 +12,12 @@ namespace cppfs
 
 
 LocalFileIterator::LocalFileIterator(std::shared_ptr<LocalFileSystem> fs, const std::string & path)
-: LocalFileIterator(fs, std::string(path))
+: LocalFileIterator(std::move(fs), std::string(path))
 {
 }
 
 LocalFileIterator::LocalFileIterator(std::shared_ptr<LocalFileSystem> fs, std::string && path)
-: m_fs(fs)
+: m_fs(std::move(fs))
 , m_path(path)
 , m_dir(nullptr)
 , m_entry(nullptr)

source/cppfs/source/posix/LocalFileSystem.cpp

@@ -32,7 +32,7 @@ FileHandle LocalFileSystem::open(std::string && path)
 {
     return FileHandle(
         std::unique_ptr<AbstractFileHandleBackend>(
-            new LocalFileHandle(shared_from_this(), path)
+            new LocalFileHandle(shared_from_this(), std::move(path))
         )
     );
 }